[PATCH] Input: synaptics-rmi4: remove unnecessary flush_workqueue()

cgel.zte@gmail.com posted 1 patch 4 years ago
drivers/input/rmi4/rmi_f54.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] Input: synaptics-rmi4: remove unnecessary flush_workqueue()
Posted by cgel.zte@gmail.com 4 years ago
From: ran jianping <ran.jianping@zte.com.cn>

All work currently pending will be done first by calling destroy_workqueue,
so there is unnecessary to flush it explicitly.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
 drivers/input/rmi4/rmi_f54.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
index 93b328c796c6..c5ce907535ef 100644
--- a/drivers/input/rmi4/rmi_f54.c
+++ b/drivers/input/rmi4/rmi_f54.c
@@ -733,7 +733,6 @@ static int rmi_f54_probe(struct rmi_function *fn)
 	v4l2_device_unregister(&f54->v4l2);
 remove_wq:
 	cancel_delayed_work_sync(&f54->work);
-	flush_workqueue(f54->workqueue);
 	destroy_workqueue(f54->workqueue);
 	return ret;
 }
-- 
2.25.1
Re: [PATCH] Input: synaptics-rmi4: remove unnecessary flush_workqueue()
Posted by Dmitry Torokhov 4 years ago
On Fri, Apr 22, 2022 at 09:33:04AM +0000, cgel.zte@gmail.com wrote:
> From: ran jianping <ran.jianping@zte.com.cn>
> 
> All work currently pending will be done first by calling destroy_workqueue,
> so there is unnecessary to flush it explicitly.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>

Applied, thank you.

-- 
Dmitry