Subject: x86/vdso/vdso2c: Memory Leak fix, Fix leak of variable name in vdso2c.c

[PATCH] Subject: x86/vdso/vdso2c: Memory Leak fix, Fix leak of variable name in vdso2c.c

Posted by ashamedbit 4 years ago

The file vdso2c.c contains a memory leak of variable 'name'.
This leak was detected by ASAN(AddressSanitizer) on local  builds.
A tool called AddressWatcher automatically attempts to fix memory
leaks suggested by ASAN. The fix has been inserted to stop the
memory leak in the file vdso2c.c.

Signed-off-by: ashamedbit <muralianiruddhan@gmail.com>
---
 arch/x86/entry/vdso/vdso2c.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/entry/vdso/vdso2c.c b/arch/x86/entry/vdso/vdso2c.c
index edfe9780f6d1..b3decd59c98e 100644
--- a/arch/x86/entry/vdso/vdso2c.c
+++ b/arch/x86/entry/vdso/vdso2c.c
@@ -246,6 +246,7 @@ int main(int argc, char **argv)
 
 	go(raw_addr, raw_len, stripped_addr, stripped_len, outfile, name);
 
+	free(name);
 	munmap(raw_addr, raw_len);
 	munmap(stripped_addr, stripped_len);
 	fclose(outfile);
-- 
2.25.1

Re: [PATCH] Subject: x86/vdso/vdso2c: Memory Leak fix, Fix leak of variable name in vdso2c.c

Posted by Peter Zijlstra 4 years ago

On Fri, Apr 22, 2022 at 03:09:22AM -0400, ashamedbit wrote:
> The file vdso2c.c contains a memory leak of variable 'name'.
> This leak was detected by ASAN(AddressSanitizer) on local  builds.
> A tool called AddressWatcher automatically attempts to fix memory
> leaks suggested by ASAN. The fix has been inserted to stop the
> memory leak in the file vdso2c.c.

I think you need to fix your tool, this is 3 lines before the program
terminates. Please explain how that is a leak?