phy: rockchip-inno-usb2: Clean up some inconsistent indenting

[PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting

Posted by Jiapeng Chong 4 years ago

Eliminate the follow smatch warning:

drivers/phy/rockchip/phy-rockchip-inno-usb2.c:1203
rockchip_usb2phy_probe() warn: inconsistent indenting.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index e377b958d9b6..6711659f727c 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
@@ -1200,8 +1200,8 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
 
 	else {
 		rphy->grf = syscon_node_to_regmap(dev->parent->of_node);
-			if (IS_ERR(rphy->grf))
-				return PTR_ERR(rphy->grf);
+		if (IS_ERR(rphy->grf))
+			return PTR_ERR(rphy->grf);
 	}
 
 	if (of_device_is_compatible(np, "rockchip,rv1108-usb2phy")) {
-- 
2.20.1.7.g153144c

Re: [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting

Posted by Vinod Koul 4 years ago

On 22-04-22, 04:30, Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
> 
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c:1203
> rockchip_usb2phy_probe() warn: inconsistent indenting.

Applied, thanks

-- 
~Vinod

Re: [PATCH] phy: rockchip-inno-usb2: Clean up some inconsistent indenting

Posted by Heiko Stuebner 4 years ago

Am Donnerstag, 21. April 2022, 22:30:38 CEST schrieb Jiapeng Chong:
> Eliminate the follow smatch warning:
> 
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c:1203
> rockchip_usb2phy_probe() warn: inconsistent indenting.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> index e377b958d9b6..6711659f727c 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> @@ -1200,8 +1200,8 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
>  
>  	else {
>  		rphy->grf = syscon_node_to_regmap(dev->parent->of_node);
> -			if (IS_ERR(rphy->grf))
> -				return PTR_ERR(rphy->grf);
> +		if (IS_ERR(rphy->grf))
> +			return PTR_ERR(rphy->grf);
>  	}
>  
>  	if (of_device_is_compatible(np, "rockchip,rv1108-usb2phy")) {
>