[PATCH 0/2] objtool: Fix code reloc vs weak symbols

Peter Zijlstra posted 2 patches 4 years ago
[PATCH 0/2] objtool: Fix code reloc vs weak symbols
Posted by Peter Zijlstra 4 years ago
Two fun bugs that make can cause other fun fail if you have a fresh enough
toolchain that strips unused section symbols.

The symptoms can vary between a faulty unwind to a kernel splat for trying to
patch the wrong text.

I found it while playing with text patching and Josh confirmed it very much
affects ORC data too.
Re: [PATCH 0/2] objtool: Fix code reloc vs weak symbols
Posted by Josh Poimboeuf 4 years ago
On Tue, Apr 19, 2022 at 10:32:54PM +0200, Peter Zijlstra wrote:
> Two fun bugs that make can cause other fun fail if you have a fresh enough
> toolchain that strips unused section symbols.
> 
> The symptoms can vary between a faulty unwind to a kernel splat for trying to
> patch the wrong text.
> 
> I found it while playing with text patching and Josh confirmed it very much
> affects ORC data too.

Seems to work ok with testing.

With the XXX comment removed or fixed:

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh