Input: aiptek - remove redundant assignment to variable ret

[PATCH] Input: aiptek - remove redundant assignment to variable ret

Posted by Colin Ian King 4 years, 2 months ago

Variable ret is being assigned a value that is never read, it is
being re-assigned again in either path of the if statement. The
assignment is redundant and can be removed.

Cleans up clang scan build warning:
Although the value stored to 'ret' is used in the enclosing expression,
the value is never actually read from 'ret' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/input/tablet/aiptek.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/input/tablet/aiptek.c b/drivers/input/tablet/aiptek.c
index 1581f6ef0927..24ec4844a5c3 100644
--- a/drivers/input/tablet/aiptek.c
+++ b/drivers/input/tablet/aiptek.c
@@ -931,8 +931,7 @@ aiptek_query(struct aiptek *aiptek, unsigned char command, unsigned char data)
 	}
 	msleep(aiptek->curSetting.programmableDelay);
 
-	if ((ret =
-	     aiptek_get_report(aiptek, 3, 2, buf, sizeof_buf)) != sizeof_buf) {
+	if (aiptek_get_report(aiptek, 3, 2, buf, sizeof_buf) != sizeof_buf) {
 		dev_dbg(&aiptek->intf->dev,
 			"aiptek_query failed: returned 0x%02x 0x%02x 0x%02x\n",
 			buf[0], buf[1], buf[2]);
-- 
2.35.1

Re: [PATCH] Input: aiptek - remove redundant assignment to variable ret

Posted by Dmitry Torokhov 4 years, 1 month ago

On Mon, Apr 18, 2022 at 03:24:57PM +0100, Colin Ian King wrote:
> Variable ret is being assigned a value that is never read, it is
> being re-assigned again in either path of the if statement. The
> assignment is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> Although the value stored to 'ret' is used in the enclosing expression,
> the value is never actually read from 'ret' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Applied, thank you.

-- 
Dmitry