fs/f2fs/gc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Fix the following smatch warning:
fs/f2fs/gc.c:688 f2fs_gc_pinned_control() warn: signedness bug returning
'(-16)'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/f2fs/gc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 34c097a7821d..4c8ce02a815b 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -679,7 +679,7 @@ static void f2fs_unpin_all_sections(struct f2fs_sb_info *sbi, bool enable)
DIRTY_I(sbi)->enable_pin_section = enable;
}
-static bool f2fs_gc_pinned_control(struct inode *inode, int gc_type,
+static int f2fs_gc_pinned_control(struct inode *inode, int gc_type,
unsigned int segno)
{
if (!f2fs_is_pinned_file(inode))
--
2.20.1.7.g153144c
On 2022/4/15 16:49, Jiapeng Chong wrote: > Fix the following smatch warning: > > fs/f2fs/gc.c:688 f2fs_gc_pinned_control() warn: signedness bug returning > '(-16)'. Oops, thanks for catching this... It's better to merge this patch into original patch, if you don't mind? Thanks,
On 04/15, Chao Yu wrote: > On 2022/4/15 16:49, Jiapeng Chong wrote: > > Fix the following smatch warning: > > > > fs/f2fs/gc.c:688 f2fs_gc_pinned_control() warn: signedness bug returning > > '(-16)'. > > Oops, thanks for catching this... > > It's better to merge this patch into original patch, if you don't mind? Applied. > > Thanks,
© 2016 - 2026 Red Hat, Inc.