[PATCH] tools/vm/page_owner_sort.c: avoid repeated judgments

Yixuan Cao posted 1 patch 4 years ago
tools/vm/page_owner_sort.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
[PATCH] tools/vm/page_owner_sort.c: avoid repeated judgments
Posted by Yixuan Cao 4 years ago
I noticed a detail that needs to be adjusted.
When judging whether a page is allocated by vmalloc,
the value of the variable "tmp" was repeatedly judged,
so the code was adjusted.

This work is coauthored by Yinan Zhang, Jiajian Ye, Shenghong Han,
Chongxi Zhao, Yuhong Feng and Yongqiang Liu.

Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
---
 tools/vm/page_owner_sort.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c
index fa2e4d2a9d68..c149427eb1c9 100644
--- a/tools/vm/page_owner_sort.c
+++ b/tools/vm/page_owner_sort.c
@@ -444,10 +444,8 @@ static int get_allocator(const char *buf, const char *migrate_info)
 			tmp--;
 		first_line = ++tmp;
 		tmp = strstr(tmp, "alloc_pages");
-		if (tmp) {
-			if (tmp && first_line <= tmp && tmp < second_line)
-				allocator |= ALLOCATOR_VMALLOC;
-		}
+		if (tmp && first_line <= tmp && tmp < second_line)
+			allocator |= ALLOCATOR_VMALLOC;
 	}
 	if (allocator == 0)
 		allocator = ALLOCATOR_OTHERS;
-- 
2.17.1