init/Kconfig: Remove USELIB syscall by default

[PATCH] init/Kconfig: Remove USELIB syscall by default

Posted by Kees Cook 4 years ago

The uselib syscall has been long deprecated. There's no need to keep
this enabled by default under X86_32.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 init/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index ddcbefe535e9..5cddb9ba0eef 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -435,8 +435,8 @@ config CROSS_MEMORY_ATTACH
 	  See the man page for more details.
 
 config USELIB
-	bool "uselib syscall"
-	def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION
+	bool "uselib syscall (for libc5 and earlier)"
+	default ALPHA || M68K || SPARC
 	help
 	  This option enables the uselib syscall, a system call used in the
 	  dynamic linker from libc5 and earlier.  glibc does not use this
-- 
2.32.0

Re: [PATCH] init/Kconfig: Remove USELIB syscall by default

Posted by Nathan Chancellor 4 years ago

On Tue, Apr 12, 2022 at 02:25:20PM -0700, Kees Cook wrote:
> The uselib syscall has been long deprecated. There's no need to keep
> this enabled by default under X86_32.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>

The 'bool "" + def_bool' was weird and I had to look up what libc5 even
was :)

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  init/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index ddcbefe535e9..5cddb9ba0eef 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -435,8 +435,8 @@ config CROSS_MEMORY_ATTACH
>  	  See the man page for more details.
>  
>  config USELIB
> -	bool "uselib syscall"
> -	def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION
> +	bool "uselib syscall (for libc5 and earlier)"
> +	default ALPHA || M68K || SPARC
>  	help
>  	  This option enables the uselib syscall, a system call used in the
>  	  dynamic linker from libc5 and earlier.  glibc does not use this
> -- 
> 2.32.0
>