[v2] MAINTAINERS: Remove D. Kershner from Unisys S-PAR maintainers

[PATCH v2] MAINTAINERS: Remove D. Kershner from Unisys S-PAR maintainers

Posted by Fabio M. De Francesco 4 years ago

The email address of David Kershner is no more reachable. Remove his
entry from the MAINTAINERS file for UNISYS S-PAR DRIVERS and change
the status to "Orphan".

Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---

v1->v2: Change also the status of the entry to "Orphan" and rework the
commit message. (Thanks to Greg Kroah-Hartman).

 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3ed62dcd144e..9283c63565b3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20184,9 +20184,8 @@ F:	include/linux/cdrom.h
 F:	include/uapi/linux/cdrom.h
 
 UNISYS S-PAR DRIVERS
-M:	David Kershner <david.kershner@unisys.com>
 L:	sparmaintainer@unisys.com (Unisys internal)
-S:	Supported
+S:	Orphan
 F:	drivers/staging/unisys/
 F:	drivers/visorbus/
 F:	include/linux/visorbus.h
-- 
2.34.1

Re: [PATCH v2] MAINTAINERS: Remove D. Kershner from Unisys S-PAR maintainers

Posted by Greg Kroah-Hartman 4 years ago

On Tue, Apr 12, 2022 at 12:36:29PM +0200, Fabio M. De Francesco wrote:
> The email address of David Kershner is no more reachable. Remove his
> entry from the MAINTAINERS file for UNISYS S-PAR DRIVERS and change
> the status to "Orphan".
> 
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> 
> v1->v2: Change also the status of the entry to "Orphan" and rework the
> commit message. (Thanks to Greg Kroah-Hartman).
> 
>  MAINTAINERS | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3ed62dcd144e..9283c63565b3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20184,9 +20184,8 @@ F:	include/linux/cdrom.h
>  F:	include/uapi/linux/cdrom.h
>  
>  UNISYS S-PAR DRIVERS
> -M:	David Kershner <david.kershner@unisys.com>
>  L:	sparmaintainer@unisys.com (Unisys internal)

Again, please drop this "list" as it obviously is not going to anyone.

And really, this whole code should be removed, no one seems to be using
it, and if they are, we can easily revert the removal and mark them as
the maintainer.

thanks,

greg k-h

Re: [PATCH v2] MAINTAINERS: Remove D. Kershner from Unisys S-PAR maintainers

Posted by Fabio M. De Francesco 4 years ago

On marted? 12 aprile 2022 12:41:27 CEST Greg Kroah-Hartman wrote:
> On Tue, Apr 12, 2022 at 12:36:29PM +0200, Fabio M. De Francesco wrote:
> > The email address of David Kershner is no more reachable. Remove his
> > entry from the MAINTAINERS file for UNISYS S-PAR DRIVERS and change
> > the status to "Orphan".
> > 
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> > 
> > v1->v2: Change also the status of the entry to "Orphan" and rework the
> > commit message. (Thanks to Greg Kroah-Hartman).
> > 
> >  MAINTAINERS | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 3ed62dcd144e..9283c63565b3 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -20184,9 +20184,8 @@ F:	include/linux/cdrom.h
> >  F:	include/uapi/linux/cdrom.h
> >  
> >  UNISYS S-PAR DRIVERS
> > -M:	David Kershner <david.kershner@unisys.com>
> >  L:	sparmaintainer@unisys.com (Unisys internal)
> 
> Again, please drop this "list" as it obviously is not going to anyone.

OK, I'll also drop the "L:" line. I wasn't sure about it because I see 
that there are other entries marked as "Orphan" and the list is still
there. But you are right: although the "sparmaintainer" list address is
not bouncing, it looks like nobody care to read messages there.

> And really, this whole code should be removed, no one seems to be using
> it, and if they are, we can easily revert the removal and mark them as
> the maintainer.

1) If I remove the entire drivers/staging/unisys/ I suppose that, in 
MAINTAINERS I should also remove the whole entry called "UNISYS S-PAR 
DRIVERS", not only the "L:" line. 

2) Furthermore, I understand that I should also should change the relevant 
Kbuild files, otherwise all builds of staging would fail. 

I'm sorry for asking but, as you probably recall, I have no prior experience 
with removing drivers from trees and with the Kbuild's infrastructure. I'll 
take some time to read how it works.

Are the two arguments above correct?

Thanks,

Fabio M. De Francesco

Re: [PATCH v2] MAINTAINERS: Remove D. Kershner from Unisys S-PAR maintainers

Posted by Sergio Paracuellos 4 years ago

Hi Fabio,

On Tue, Apr 12, 2022 at 1:08 PM Fabio M. De Francesco
<fmdefrancesco@gmail.com> wrote:
>
> On marted? 12 aprile 2022 12:41:27 CEST Greg Kroah-Hartman wrote:
> > On Tue, Apr 12, 2022 at 12:36:29PM +0200, Fabio M. De Francesco wrote:
> > > The email address of David Kershner is no more reachable. Remove his
> > > entry from the MAINTAINERS file for UNISYS S-PAR DRIVERS and change
> > > the status to "Orphan".
> > >
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > ---
> > >
> > > v1->v2: Change also the status of the entry to "Orphan" and rework the
> > > commit message. (Thanks to Greg Kroah-Hartman).
> > >
> > >  MAINTAINERS | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 3ed62dcd144e..9283c63565b3 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -20184,9 +20184,8 @@ F:  include/linux/cdrom.h
> > >  F: include/uapi/linux/cdrom.h
> > >
> > >  UNISYS S-PAR DRIVERS
> > > -M: David Kershner <david.kershner@unisys.com>
> > >  L: sparmaintainer@unisys.com (Unisys internal)
> >
> > Again, please drop this "list" as it obviously is not going to anyone.
>
> OK, I'll also drop the "L:" line. I wasn't sure about it because I see
> that there are other entries marked as "Orphan" and the list is still
> there. But you are right: although the "sparmaintainer" list address is
> not bouncing, it looks like nobody care to read messages there.
>
> > And really, this whole code should be removed, no one seems to be using
> > it, and if they are, we can easily revert the removal and mark them as
> > the maintainer.
>
> 1) If I remove the entire drivers/staging/unisys/ I suppose that, in
> MAINTAINERS I should also remove the whole entry called "UNISYS S-PAR
> DRIVERS", not only the "L:" line.
>
> 2) Furthermore, I understand that I should also should change the relevant
> Kbuild files, otherwise all builds of staging would fail.

Correct.

>
> I'm sorry for asking but, as you probably recall, I have no prior experience
> with removing drivers from trees and with the Kbuild's infrastructure. I'll
> take some time to read how it works.

Check this patchset [0] I sent a bit time ago removing two drivers from staging,

Hope this helps.

Regards,
    Sergio Paracuellos

[0]: https://lore.kernel.org/all/20211113192045.32153-4-sergio.paracuellos@gmail.com/T/
>
> Are the two arguments above correct?
>
> Thanks,
>
> Fabio M. De Francesco
>
>
>
>

Re: [PATCH v2] MAINTAINERS: Remove D. Kershner from Unisys S-PAR maintainers

Posted by Fabio M. De Francesco 4 years ago

Hi Sergio,

On martedì 12 aprile 2022 13:30:43 CEST Sergio Paracuellos wrote:
> Hi Fabio,
> 
> Check this patchset [0] I sent a bit time ago removing two drivers from staging,
> 
> Hope this helps.
> 
> Regards,
>     Sergio Paracuellos
> 
> [0]: https://lore.kernel.org/all/20211113192045.32153-4-sergio.paracuellos@gmail.com/T/

Thank you very much for the link to your patchset :)

I have just taken a look at it. I'm pretty sure that it will be very useful
for accomplishing the task of removing the unisys sub-tree. I've planned to
do this work by the end of the current week.

Regards,

Fabio M. De Francesco

Re: [PATCH v2] MAINTAINERS: Remove D. Kershner from Unisys S-PAR maintainers

Posted by Greg Kroah-Hartman 4 years ago

On Tue, Apr 12, 2022 at 01:08:28PM +0200, Fabio M. De Francesco wrote:
> On marted? 12 aprile 2022 12:41:27 CEST Greg Kroah-Hartman wrote:
> > On Tue, Apr 12, 2022 at 12:36:29PM +0200, Fabio M. De Francesco wrote:
> > > The email address of David Kershner is no more reachable. Remove his
> > > entry from the MAINTAINERS file for UNISYS S-PAR DRIVERS and change
> > > the status to "Orphan".
> > > 
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > ---
> > > 
> > > v1->v2: Change also the status of the entry to "Orphan" and rework the
> > > commit message. (Thanks to Greg Kroah-Hartman).
> > > 
> > >  MAINTAINERS | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 3ed62dcd144e..9283c63565b3 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -20184,9 +20184,8 @@ F:	include/linux/cdrom.h
> > >  F:	include/uapi/linux/cdrom.h
> > >  
> > >  UNISYS S-PAR DRIVERS
> > > -M:	David Kershner <david.kershner@unisys.com>
> > >  L:	sparmaintainer@unisys.com (Unisys internal)
> > 
> > Again, please drop this "list" as it obviously is not going to anyone.
> 
> OK, I'll also drop the "L:" line. I wasn't sure about it because I see 
> that there are other entries marked as "Orphan" and the list is still
> there. But you are right: although the "sparmaintainer" list address is
> not bouncing, it looks like nobody care to read messages there.
>   
> > And really, this whole code should be removed, no one seems to be using
> > it, and if they are, we can easily revert the removal and mark them as
> > the maintainer.
> 
> 1) If I remove the entire drivers/staging/unisys/ I suppose that, in 
> MAINTAINERS I should also remove the whole entry called "UNISYS S-PAR 
> DRIVERS", not only the "L:" line. 

Yes, _AND_ you need to also remove all files that are listed for that
entry.

> 2) Furthermore, I understand that I should also should change the relevant 
> Kbuild files, otherwise all builds of staging would fail. 

Yes.

thanks,

greg k-h