[PATCH 0/2] gpiolib: of: Introduce hook for missing gpio-ranges

Stefan Wahren posted 2 patches 4 years, 1 month ago
drivers/gpio/gpiolib-of.c             |  5 +++++
drivers/pinctrl/bcm/pinctrl-bcm2835.c | 18 ++++++++++++++++++
include/linux/gpio/driver.h           | 12 ++++++++++++
3 files changed, 35 insertions(+)
[PATCH 0/2] gpiolib: of: Introduce hook for missing gpio-ranges
Posted by Stefan Wahren 4 years, 1 month ago
This patch series tries to provide backward compatibility for DTB which
lacks the gpio-ranges property.

The commit ("pinctrl: msm: fix gpio-hog related boot issues") by Christian
Lamparter already contains a fallback in case the gpio-ranges property
is missing. But this approach doesn't work on BCM2835 with a gpio-hog
defined for the SoC GPIOs.

Based Christian's on explanation i conclude that the fallback must happen
during the gpiochip_add() call and not afterwards. So the approach is to
call an optional hook, which can be implemented in the platform driver.

This series has been tested on Raspberry Pi 3 B Plus.

Changes since RFC:
- just add all collected Fixes, Reviewed-by, Tested-by and Acked-by

Stefan Wahren (2):
  gpiolib: of: Introduce hook for missing gpio-ranges
  pinctrl: bcm2835: implement hook for missing gpio-ranges

 drivers/gpio/gpiolib-of.c             |  5 +++++
 drivers/pinctrl/bcm/pinctrl-bcm2835.c | 18 ++++++++++++++++++
 include/linux/gpio/driver.h           | 12 ++++++++++++
 3 files changed, 35 insertions(+)

-- 
2.25.1
Re: [PATCH 0/2] gpiolib: of: Introduce hook for missing gpio-ranges
Posted by Linus Walleij 4 years ago
On Sat, Apr 9, 2022 at 11:52 AM Stefan Wahren <stefan.wahren@i2se.com> wrote:

> This patch series tries to provide backward compatibility for DTB which
> lacks the gpio-ranges property.
>
> The commit ("pinctrl: msm: fix gpio-hog related boot issues") by Christian
> Lamparter already contains a fallback in case the gpio-ranges property
> is missing. But this approach doesn't work on BCM2835 with a gpio-hog
> defined for the SoC GPIOs.
>
> Based Christian's on explanation i conclude that the fallback must happen
> during the gpiochip_add() call and not afterwards. So the approach is to
> call an optional hook, which can be implemented in the platform driver.
>
> This series has been tested on Raspberry Pi 3 B Plus.
>
> Changes since RFC:
> - just add all collected Fixes, Reviewed-by, Tested-by and Acked-by

Patches applied!

Sorry for being a bit slow on this :/

Yours,
Linus Walleij