[PATCH] phy: ti: Fix missing of_node_put in ti_pipe3_get_sysctrl()

cgel.zte@gmail.com posted 1 patch 4 years, 1 month ago
drivers/phy/ti/phy-ti-pipe3.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] phy: ti: Fix missing of_node_put in ti_pipe3_get_sysctrl()
Posted by cgel.zte@gmail.com 4 years, 1 month ago
From: Lv Ruyi <lv.ruyi@zte.com.cn>

of_parse_phandle() returns node pointer with refcount incremented, use
of_node_put() on it to decrease refcount when done.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
 drivers/phy/ti/phy-ti-pipe3.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/ti/phy-ti-pipe3.c b/drivers/phy/ti/phy-ti-pipe3.c
index 2cbc91e535d4..f502c36f3be5 100644
--- a/drivers/phy/ti/phy-ti-pipe3.c
+++ b/drivers/phy/ti/phy-ti-pipe3.c
@@ -696,6 +696,7 @@ static int ti_pipe3_get_sysctrl(struct ti_pipe3 *phy)
 		}
 
 		control_pdev = of_find_device_by_node(control_node);
+		of_node_put(control_node);
 		if (!control_pdev) {
 			dev_err(dev, "Failed to get control device\n");
 			return -EINVAL;
-- 
2.25.1
Re: [PATCH] phy: ti: Fix missing of_node_put in ti_pipe3_get_sysctrl()
Posted by Vinod Koul 4 years ago
On 08-04-22, 09:56, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
> 
> of_parse_phandle() returns node pointer with refcount incremented, use
> of_node_put() on it to decrease refcount when done.

Applied, thanks

-- 
~Vinod