[v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties

[PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties

Posted by Krzysztof Kozlowski 4 years, 1 month ago

After conversion the jedec,spi-nor DT schema to reference other schemas
(SPI and MTD) and use unevaluatedProperties, few properties are
redundant.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>

---

Changes since v1:
1. Do not remove address/size cells (Rob).
2. Add Pratyush review.
---
 Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
index 4abfb4cfc157..7149784a36ac 100644
--- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
+++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
@@ -50,10 +50,6 @@ properties:
     minItems: 1
     maxItems: 2
 
-  spi-max-frequency: true
-  spi-rx-bus-width: true
-  spi-tx-bus-width: true
-
   m25p,fast-read:
     type: boolean
     description:
@@ -74,8 +70,6 @@ properties:
       be used on such systems, to denote the absence of a reliable reset
       mechanism.
 
-  label: true
-
   partitions:
     type: object
 
@@ -99,8 +93,6 @@ examples:
         #size-cells = <0>;
 
         flash@0 {
-            #address-cells = <1>;
-            #size-cells = <1>;
             compatible = "spansion,m25p80", "jedec,spi-nor";
             reg = <0>;
             spi-max-frequency = <40000000>;
-- 
2.32.0

Re: [PATCH v2] dt-bindings: mtd: jedec, spi-nor: remove unneeded properties

Posted by Miquel Raynal 4 years, 1 month ago

On Fri, 2022-04-08 at 06:37:20 UTC, Krzysztof Kozlowski wrote:
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, few properties are
> redundant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

Re: [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties

Posted by Tudor.Ambarus@microchip.com 4 years, 1 month ago

On 4/8/22 09:37, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, few properties are
> redundant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Pratyush Yadav <p.yadav@ti.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> 
> ---
> 
> Changes since v1:
> 1. Do not remove address/size cells (Rob).
> 2. Add Pratyush review.
> ---
>  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> index 4abfb4cfc157..7149784a36ac 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> @@ -50,10 +50,6 @@ properties:
>      minItems: 1
>      maxItems: 2
> 
> -  spi-max-frequency: true
> -  spi-rx-bus-width: true
> -  spi-tx-bus-width: true
> -
>    m25p,fast-read:
>      type: boolean
>      description:
> @@ -74,8 +70,6 @@ properties:
>        be used on such systems, to denote the absence of a reliable reset
>        mechanism.
> 
> -  label: true
> -
>    partitions:
>      type: object
> 
> @@ -99,8 +93,6 @@ examples:
>          #size-cells = <0>;
> 
>          flash@0 {
> -            #address-cells = <1>;
> -            #size-cells = <1>;
>              compatible = "spansion,m25p80", "jedec,spi-nor";
>              reg = <0>;
>              spi-max-frequency = <40000000>;
> --
> 2.32.0
>

Re: [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties

Posted by Rob Herring 4 years, 1 month ago

On Fri, 08 Apr 2022 08:37:20 +0200, Krzysztof Kozlowski wrote:
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, few properties are
> redundant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
> 
> ---
> 
> Changes since v1:
> 1. Do not remove address/size cells (Rob).
> 2. Add Pratyush review.
> ---
>  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 8 --------
>  1 file changed, 8 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>