[PATCH -next] ath11k: fix missing unlock on error in ath11k_wow_op_resume()

Yang Yingliang posted 1 patch 4 years, 2 months ago
drivers/net/wireless/ath/ath11k/wow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH -next] ath11k: fix missing unlock on error in ath11k_wow_op_resume()
Posted by Yang Yingliang 4 years, 2 months ago
Add the missing unlock before return from function ath11k_wow_op_resume()
in the error handling case.

Fixes: 90bf5c8d0f7e ("ath11k: purge rx pktlog when entering WoW")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/net/wireless/ath/ath11k/wow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/wow.c b/drivers/net/wireless/ath/ath11k/wow.c
index 6c2611f93739..9d088cebef03 100644
--- a/drivers/net/wireless/ath/ath11k/wow.c
+++ b/drivers/net/wireless/ath/ath11k/wow.c
@@ -758,7 +758,7 @@ int ath11k_wow_op_resume(struct ieee80211_hw *hw)
 	ret = ath11k_dp_rx_pktlog_start(ar->ab);
 	if (ret) {
 		ath11k_warn(ar->ab, "failed to start rx pktlog from wow: %d\n", ret);
-		return ret;
+		goto exit;
 	}
 
 	ret = ath11k_wow_wakeup(ar->ab);
-- 
2.25.1
Re: [PATCH -next] ath11k: fix missing unlock on error in ath11k_wow_op_resume()
Posted by Kalle Valo 4 years, 1 month ago
Yang Yingliang <yangyingliang@huawei.com> wrote:

> Add the missing unlock before return from function ath11k_wow_op_resume()
> in the error handling case.
> 
> Fixes: 90bf5c8d0f7e ("ath11k: purge rx pktlog when entering WoW")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

605194411d73 ath11k: fix missing unlock on error in ath11k_wow_op_resume()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches