[PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig

Coco Li posted 1 patch 4 years, 1 month ago
There is a newer version of this series
net/ipv4/Kconfig | 1 -
1 file changed, 1 deletion(-)
[PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig
Posted by Coco Li 4 years, 1 month ago
XRFM is no longer needed for configuring FOU tunnels
(CONFIG_NET_FOU_IP_TUNNELS), remove from Kconfig.

Built and installed kernel and setup GUE/FOU tunnels.

Signed-off-by: Coco Li <lixiaoyan@google.com>
---
 net/ipv4/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 87983e70f03f..e983bb0c5012 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -321,7 +321,6 @@ config NET_UDP_TUNNEL
 
 config NET_FOU
 	tristate "IP: Foo (IP protocols) over UDP"
-	select XFRM
 	select NET_UDP_TUNNEL
 	help
 	  Foo over UDP allows any IP protocol to be directly encapsulated
-- 
2.35.1.1178.g4f1659d476-goog
Re: [PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig
Posted by Jakub Kicinski 4 years, 1 month ago
On Thu,  7 Apr 2022 10:15:54 -0700 Coco Li wrote:
> XRFM is no longer needed for configuring FOU tunnels
> (CONFIG_NET_FOU_IP_TUNNELS), remove from Kconfig.

What's the full story? The original code mentions udp_encap_rcv 
but would be used to note where that dependency got removed.

> Built and installed kernel and setup GUE/FOU tunnels.
> 
> Signed-off-by: Coco Li <lixiaoyan@google.com>
> ---
>  net/ipv4/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index 87983e70f03f..e983bb0c5012 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -321,7 +321,6 @@ config NET_UDP_TUNNEL
>  
>  config NET_FOU
>  	tristate "IP: Foo (IP protocols) over UDP"
> -	select XFRM
>  	select NET_UDP_TUNNEL
>  	help
>  	  Foo over UDP allows any IP protocol to be directly encapsulated

I think we can also remove the include of xfrm.h from fou.c ?