iio: adc: Kconfig: Make RZG2L_ADC depend on ARCH_RZG2L

[PATCH] iio: adc: Kconfig: Make RZG2L_ADC depend on ARCH_RZG2L

Posted by Lad Prabhakar 4 years, 2 months ago

ADC block is common on Renesas RZ/G2L and RZ/V2L SoC's, so instead of
adding dependency for each SoC's add dependency on ARCH_RZG2L. The
ARCH_RZG2L config option is already selected by ARCH_R9A07G044 and
ARCH_R9A07G054.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/iio/adc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 71ab0a06aa82..48ace7412874 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -910,7 +910,7 @@ config ROCKCHIP_SARADC
 
 config RZG2L_ADC
 	tristate "Renesas RZ/G2L ADC driver"
-	depends on ARCH_R9A07G044 || COMPILE_TEST
+	depends on ARCH_RZG2L || COMPILE_TEST
 	help
 	  Say yes here to build support for the ADC found in Renesas
 	  RZ/G2L family.
-- 
2.17.1

Re: [PATCH] iio: adc: Kconfig: Make RZG2L_ADC depend on ARCH_RZG2L

Posted by Jonathan Cameron 4 years, 2 months ago

On Wed,  6 Apr 2022 08:03:15 +0100
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:

> ADC block is common on Renesas RZ/G2L and RZ/V2L SoC's, so instead of
> adding dependency for each SoC's add dependency on ARCH_RZG2L. The
> ARCH_RZG2L config option is already selected by ARCH_R9A07G044 and
> ARCH_R9A07G054.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Sounds like a fix?

If so, please supply a Fixes tag.
no need to resend, just reply with one to this email.

thanks,

Jonathan

> ---
>  drivers/iio/adc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 71ab0a06aa82..48ace7412874 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -910,7 +910,7 @@ config ROCKCHIP_SARADC
>  
>  config RZG2L_ADC
>  	tristate "Renesas RZ/G2L ADC driver"
> -	depends on ARCH_R9A07G044 || COMPILE_TEST
> +	depends on ARCH_RZG2L || COMPILE_TEST
>  	help
>  	  Say yes here to build support for the ADC found in Renesas
>  	  RZ/G2L family.

Re: [PATCH] iio: adc: Kconfig: Make RZG2L_ADC depend on ARCH_RZG2L

Posted by Geert Uytterhoeven 4 years, 2 months ago

Hi Jonathan,

On Sun, Apr 10, 2022 at 7:52 PM Jonathan Cameron <jic23@kernel.org> wrote:
> On Wed,  6 Apr 2022 08:03:15 +0100
> Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
>
> > ADC block is common on Renesas RZ/G2L and RZ/V2L SoC's, so instead of
> > adding dependency for each SoC's add dependency on ARCH_RZG2L. The
> > ARCH_RZG2L config option is already selected by ARCH_R9A07G044 and
> > ARCH_R9A07G054.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> Sounds like a fix?
>
> If so, please supply a Fixes tag.
> no need to resend, just reply with one to this email.

This is not really a fix, as the original dependency was correct at
that time.
This is a change to add support for the RZ/V2L (r9a07g054) SoC, and
avoiding the need to update the dependencies when support is added
for more SoCs of the RZ/G2L family later.

> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -910,7 +910,7 @@ config ROCKCHIP_SARADC
> >
> >  config RZG2L_ADC
> >       tristate "Renesas RZ/G2L ADC driver"
> > -     depends on ARCH_R9A07G044 || COMPILE_TEST
> > +     depends on ARCH_RZG2L || COMPILE_TEST
> >       help
> >         Say yes here to build support for the ADC found in Renesas
> >         RZ/G2L family.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] iio: adc: Kconfig: Make RZG2L_ADC depend on ARCH_RZG2L

Posted by Jonathan Cameron 4 years, 2 months ago

On Mon, 11 Apr 2022 16:40:20 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Jonathan,
> 
> On Sun, Apr 10, 2022 at 7:52 PM Jonathan Cameron <jic23@kernel.org> wrote:
> > On Wed,  6 Apr 2022 08:03:15 +0100
> > Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> >  
> > > ADC block is common on Renesas RZ/G2L and RZ/V2L SoC's, so instead of
> > > adding dependency for each SoC's add dependency on ARCH_RZG2L. The
> > > ARCH_RZG2L config option is already selected by ARCH_R9A07G044 and
> > > ARCH_R9A07G054.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>  
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied. Thanks,

Jonathan

> 
> > Sounds like a fix?
> >
> > If so, please supply a Fixes tag.
> > no need to resend, just reply with one to this email.  
> 
> This is not really a fix, as the original dependency was correct at
> that time.
> This is a change to add support for the RZ/V2L (r9a07g054) SoC, and
> avoiding the need to update the dependencies when support is added
> for more SoCs of the RZ/G2L family later.
> 
> > > --- a/drivers/iio/adc/Kconfig
> > > +++ b/drivers/iio/adc/Kconfig
> > > @@ -910,7 +910,7 @@ config ROCKCHIP_SARADC
> > >
> > >  config RZG2L_ADC
> > >       tristate "Renesas RZ/G2L ADC driver"
> > > -     depends on ARCH_R9A07G044 || COMPILE_TEST
> > > +     depends on ARCH_RZG2L || COMPILE_TEST
> > >       help
> > >         Say yes here to build support for the ADC found in Renesas
> > >         RZ/G2L family.  
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds