[v1] mailbox: remove an unneeded NULL check on list iterator

[RESEND][PATCH] mailbox: remove an unneeded NULL check on list iterator

Xiaomeng Tong posted 1 patch 4 years, 2 months ago

Diff against v1
Download mbox

drivers/mailbox/tegra-hsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[RESEND][PATCH] mailbox: remove an unneeded NULL check on list iterator

Posted by Xiaomeng Tong 4 years, 2 months ago

The list iterator is always non-NULL so it doesn't need to be checked.
Thus just remove the unnecessary NULL check.

Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
---
 drivers/mailbox/tegra-hsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c
index acd0675da681..64eaee089b03 100644
--- a/drivers/mailbox/tegra-hsp.c
+++ b/drivers/mailbox/tegra-hsp.c
@@ -799,7 +799,7 @@ static int __maybe_unused tegra_hsp_resume(struct device *dev)
 	struct tegra_hsp_doorbell *db;
 
 	list_for_each_entry(db, &hsp->doorbells, list) {
-		if (db && db->channel.chan)
+		if (db->channel.chan)
 			tegra_hsp_doorbell_startup(db->channel.chan);
 	}
 
-- 
2.17.1