From: Tom Rix <trix@redhat.com>

cppcheck returns this warning
btintel.c:1059]: (warning) Function 'btintel_download_firmware'
  argument order different: declaration
  'dev, fw, boot_param, ' definition 'hdev, ver, fw, boot_param'

By inspection, the stub version is missing
'struct intel_version *ver', so add it.

Fixes: ac0565462e33 ("Bluetooth: btintel: Check firmware version before download")
Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/bluetooth/btintel.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
index e0060e58573c..66902866a5c1 100644
--- a/drivers/bluetooth/btintel.h
+++ b/drivers/bluetooth/btintel.h
@@ -281,6 +281,7 @@ static inline int btintel_read_boot_params(struct hci_dev *hdev,
 }
 
 static inline int btintel_download_firmware(struct hci_dev *dev,
+					    struct intel_version *ver,
 					    const struct firmware *fw,
 					    u32 *boot_param)
 {
-- 
2.26.3

Hi Tom,

> On Mar 31, 2022, at 19:49, trix@redhat.com wrote:
> 
> <Mail Attachment>

please fix your email client to send this properly inline. Or use git-send-email.

Regards

Marcel

On 4/1/22 10:22 AM, Marcel Holtmann wrote:
> Hi Tom,
>
>> On Mar 31, 2022, at 19:49, trix@redhat.com wrote:
>>
>> <Mail Attachment>
> please fix your email client to send this properly inline. Or use git-send-email.

I did use git-send-email.

I am not sure what the problem is.

Tom

>
> Regards
>
> Marcel
>