kbuild: uapi: use -fsyntax-only rather than -S

[PATCH] kbuild: uapi: use -fsyntax-only rather than -S

Posted by Nick Desaulniers 4 years, 2 months ago

The UAPI header tests are checking that the generated headers do not
have syntax errors. There's no need to run the rest of the compilation
pipeline after semantic analysis has run. Replace -S -o /dev/null with
-fsyntax-only.

Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
 usr/include/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/usr/include/Makefile b/usr/include/Makefile
index 7b283d43f00d..bf193e205dbe 100644
--- a/usr/include/Makefile
+++ b/usr/include/Makefile
@@ -89,7 +89,7 @@ extra-y := $(patsubst $(obj)/%.h,%.hdrtest, $(shell find $(obj) -name '*.h' 2>/d
 # Include the header twice to detect missing include guard.
 quiet_cmd_hdrtest = HDRTEST $<
       cmd_hdrtest = \
-		$(CC) $(c_flags) -S -o /dev/null -x c /dev/null \
+		$(CC) $(c_flags) -fsyntax-only -x c /dev/null \
 			$(if $(filter-out $(no-header-test), $*.h), -include $< -include $<); \
 		$(PERL) $(srctree)/$(src)/headers_check.pl $(obj) $(SRCARCH) $<; \
 		touch $@

base-commit: 74164d284b2909de0ba13518cc063e9ea9334749
-- 
2.35.1.1021.g381101b075-goog

Re: [PATCH] kbuild: uapi: use -fsyntax-only rather than -S

Posted by Masahiro Yamada 4 years, 2 months ago

On Thu, Mar 31, 2022 at 3:34 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> The UAPI header tests are checking that the generated headers do not
> have syntax errors. There's no need to run the rest of the compilation
> pipeline after semantic analysis has run. Replace -S -o /dev/null with
> -fsyntax-only.
>

Applied to linux-kbuild.
Thanks.


> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
>  usr/include/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/usr/include/Makefile b/usr/include/Makefile
> index 7b283d43f00d..bf193e205dbe 100644
> --- a/usr/include/Makefile
> +++ b/usr/include/Makefile
> @@ -89,7 +89,7 @@ extra-y := $(patsubst $(obj)/%.h,%.hdrtest, $(shell find $(obj) -name '*.h' 2>/d
>  # Include the header twice to detect missing include guard.
>  quiet_cmd_hdrtest = HDRTEST $<
>        cmd_hdrtest = \
> -               $(CC) $(c_flags) -S -o /dev/null -x c /dev/null \
> +               $(CC) $(c_flags) -fsyntax-only -x c /dev/null \
>                         $(if $(filter-out $(no-header-test), $*.h), -include $< -include $<); \
>                 $(PERL) $(srctree)/$(src)/headers_check.pl $(obj) $(SRCARCH) $<; \
>                 touch $@
>
> base-commit: 74164d284b2909de0ba13518cc063e9ea9334749
> --
> 2.35.1.1021.g381101b075-goog
>


-- 
Best Regards
Masahiro Yamada