1. Patchew
  2. linux
  3. [PATCH v12 0/3] Add basic SoC support for mediatek mt8195
  4. View patch

[PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems

Tinghan Shen posted 3 patches 2 years, 5 months ago
There is a newer version of this series
[PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems
Posted by Tinghan Shen 2 years, 5 months ago 
Add optional host top register base for the reg binding description.

Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
 Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
index 7032f7adf3ca..6d41bcec900f 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -40,7 +40,8 @@ properties:
           - const: mediatek,mt8183-mmc
 
   reg:
-    maxItems: 1
+    minItems: 1
+    maxItems: 2
 
   clocks:
     description:
-- 
2.18.0
Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems
Posted by AngeloGioacchino Del Regno 2 years, 5 months ago 
Il 29/03/22 13:45, Tinghan Shen ha scritto:
> Add optional host top register base for the reg binding description.
> 
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
>   Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 7032f7adf3ca..6d41bcec900f 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -40,7 +40,8 @@ properties:
>             - const: mediatek,mt8183-mmc
>   
>     reg:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 2

it's just maxItems... adding minItems: 1 is not required.

>   
>     clocks:
>       description:
Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems
Posted by Rob Herring 2 years, 5 months ago 
On Tue, Mar 29, 2022 at 7:43 AM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 29/03/22 13:45, Tinghan Shen ha scritto:
> > Add optional host top register base for the reg binding description.
> >
> > Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > ---
> >   Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index 7032f7adf3ca..6d41bcec900f 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -40,7 +40,8 @@ properties:
> >             - const: mediatek,mt8183-mmc
> >
> >     reg:
> > -    maxItems: 1
> > +    minItems: 1
> > +    maxItems: 2
>
> it's just maxItems... adding minItems: 1 is not required.

If 1 entry is still valid, then minItems is required. If not, then
it's an ABI break.

Rob
Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems
Posted by AngeloGioacchino Del Regno 2 years, 5 months ago 
Il 29/03/22 21:10, Rob Herring ha scritto:
> On Tue, Mar 29, 2022 at 7:43 AM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>>
>> Il 29/03/22 13:45, Tinghan Shen ha scritto:
>>> Add optional host top register base for the reg binding description.
>>>
>>> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
>>> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
>>> ---
>>>    Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> index 7032f7adf3ca..6d41bcec900f 100644
>>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> @@ -40,7 +40,8 @@ properties:
>>>              - const: mediatek,mt8183-mmc
>>>
>>>      reg:
>>> -    maxItems: 1
>>> +    minItems: 1
>>> +    maxItems: 2
>>
>> it's just maxItems... adding minItems: 1 is not required.
> 
> If 1 entry is still valid, then minItems is required. If not, then
> it's an ABI break.
> 
> Rob


Right. Sorry for that and thanks for the explaination, Rob.

Cheers,
Angelo
Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems
Posted by Matthias Brugger 2 years, 5 months ago 

On 29/03/2022 13:45, Tinghan Shen wrote:
> Add optional host top register base for the reg binding description.
> 

Is this based a on a new version of the IP? Shall we make the second reg 
mandatory for the new HW? If I remember correctly the reg needs to be restored 
after power save event. So I suppose mmc won't work if that's not done. So 
optional wouldn't be the right approach.

Can you please clarify if that's the case.

Thanks,
Matthias

> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
>   Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 7032f7adf3ca..6d41bcec900f 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -40,7 +40,8 @@ properties:
>             - const: mediatek,mt8183-mmc
>   
>     reg:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 2
>   
>     clocks:
>       description:
Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems
Posted by Tinghan Shen 2 years, 5 months ago 
Hi Matthias,

On Tue, 2022-03-29 at 16:27 +0200, Matthias Brugger wrote:
> 
> On 29/03/2022 13:45, Tinghan Shen wrote:
> > Add optional host top register base for the reg binding description.
> > 
> 
> Is this based a on a new version of the IP? Shall we make the second reg 
> mandatory for the new HW? If I remember correctly the reg needs to be restored 
> after power save event. So I suppose mmc won't work if that's not done. So 
> optional wouldn't be the right approach.
> 
> Can you please clarify if that's the case.

Yes. This change is introduced since mt8183, and the host top register 
is required for mt8183. 

We'll try to describe this change clearly in bindings in next version.


Best regards,
Tinghan

> 
> Thanks,
> Matthias
> 
> > Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > ---
> >   Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index 7032f7adf3ca..6d41bcec900f 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -40,7 +40,8 @@ properties:
> >             - const: mediatek,mt8183-mmc
> >   
> >     reg:
> > -    maxItems: 1
> > +    minItems: 1
> > +    maxItems: 2
> >   
> >     clocks:
> >       description:
Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems
Posted by Rob Herring 2 years, 5 months ago 
On Tue, Mar 29, 2022 at 07:45:39PM +0800, Tinghan Shen wrote:
> Add optional host top register base for the reg binding description.
> 
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
>  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 7032f7adf3ca..6d41bcec900f 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -40,7 +40,8 @@ properties:
>            - const: mediatek,mt8183-mmc
>  
>    reg:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 2

If more than 1 entry, then you need to define what each one is.

>  
>    clocks:
>      description:
> -- 
> 2.18.0
> 
>
Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems
Posted by Tinghan Shen 2 years, 5 months ago 
Hi Rob,

On Tue, 2022-03-29 at 15:38 -0500, Rob Herring wrote:
> On Tue, Mar 29, 2022 at 07:45:39PM +0800, Tinghan Shen wrote:
> > Add optional host top register base for the reg binding description.
> > 
> > Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index 7032f7adf3ca..6d41bcec900f 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -40,7 +40,8 @@ properties:
> >            - const: mediatek,mt8183-mmc
> >  
> >    reg:
> > -    maxItems: 1
> > +    minItems: 1
> > +    maxItems: 2
> 
> If more than 1 entry, then you need to define what each one is.

Ok. I'll add definitions at next version.
Thank you.


Best regards,
Tinghan

> 
> >  
> >    clocks:
> >      description:
> > -- 
> > 2.18.0
> > 
> >

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.