[PATCH -next] pinctrl: nuvoton: wpcm450: Fix build error without OF

Zheng Bin posted 1 patch 4 years, 2 months ago
drivers/pinctrl/nuvoton/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH -next] pinctrl: nuvoton: wpcm450: Fix build error without OF
Posted by Zheng Bin 4 years, 2 months ago
If OF is not set, bulding fails:

drivers/pinctrl/nuvoton/pinctrl-wpcm450.o: In function `wpcm450_dt_node_to_map':
pinctrl-wpcm450.c:(.text+0x404): undefined reference to `pinconf_generic_dt_node_to_map'

Make PINCTRL_WPCM450 depends on OF to fix this.

Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
 drivers/pinctrl/nuvoton/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
index b48d32912bef..852b0d0eb08e 100644
--- a/drivers/pinctrl/nuvoton/Kconfig
+++ b/drivers/pinctrl/nuvoton/Kconfig
@@ -3,6 +3,7 @@
 config PINCTRL_WPCM450
 	tristate "Pinctrl and GPIO driver for Nuvoton WPCM450"
 	depends on ARCH_WPCM450 || COMPILE_TEST
+	depends on OF
 	select PINMUX
 	select PINCONF
 	select GENERIC_PINCONF
--
2.31.1
Re: [PATCH -next] pinctrl: nuvoton: wpcm450: Fix build error without OF
Posted by Linus Walleij 4 years, 2 months ago
On Fri, Mar 25, 2022 at 8:30 AM Zheng Bin <zhengbin13@huawei.com> wrote:

> If OF is not set, bulding fails:
>
> drivers/pinctrl/nuvoton/pinctrl-wpcm450.o: In function `wpcm450_dt_node_to_map':
> pinctrl-wpcm450.c:(.text+0x404): undefined reference to `pinconf_generic_dt_node_to_map'
>
> Make PINCTRL_WPCM450 depends on OF to fix this.
>
> Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>

Patch applied, thanks for fixing this so quickly Zheng!

Yours,
Linus Walleij