auxdisplay: lcd2s: use simple i2c probe function

[PATCH] auxdisplay: lcd2s: use simple i2c probe function

Posted by Stephen Kitt 4 years, 2 months ago

The i2c probe functions here don't use the id information provided in
their second argument, so the single-parameter i2c probe function
("probe_new") can be used instead.

This avoids scanning the identifier tables during probes.

Signed-off-by: Stephen Kitt <steve@sk2.org>
---
 drivers/auxdisplay/lcd2s.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/auxdisplay/lcd2s.c b/drivers/auxdisplay/lcd2s.c
index 2578b2d45439..0c64b46dbb71 100644
--- a/drivers/auxdisplay/lcd2s.c
+++ b/drivers/auxdisplay/lcd2s.c
@@ -286,8 +286,7 @@ static const struct charlcd_ops lcd2s_ops = {
 	.redefine_char	= lcd2s_redefine_char,
 };
 
-static int lcd2s_i2c_probe(struct i2c_client *i2c,
-				const struct i2c_device_id *id)
+static int lcd2s_i2c_probe(struct i2c_client *i2c)
 {
 	struct charlcd *lcd;
 	struct lcd2s_data *lcd2s;
@@ -370,7 +369,7 @@ static struct i2c_driver lcd2s_i2c_driver = {
 		.of_match_table = of_match_ptr(lcd2s_of_table),
 #endif
 	},
-	.probe = lcd2s_i2c_probe,
+	.probe_new = lcd2s_i2c_probe,
 	.remove = lcd2s_i2c_remove,
 	.id_table = lcd2s_i2c_id,
 };
-- 
2.27.0

Re: [PATCH] auxdisplay: lcd2s: use simple i2c probe function

Posted by Miguel Ojeda 4 years, 2 months ago

Hi Stephen,

On Thu, Mar 24, 2022 at 6:10 PM Stephen Kitt <steve@sk2.org> wrote:
>
> The i2c probe functions here don't use the id information provided in
> their second argument, so the single-parameter i2c probe function
> ("probe_new") can be used instead.
>
> This avoids scanning the identifier tables during probes.

Thanks for the patch -- Andy submitted an equivalent one which I
queued for -next some days ago.

Cheers,
Miguel

Re: [PATCH] auxdisplay: lcd2s: use simple i2c probe function

Posted by Stephen Kitt 4 years, 2 months ago

Hi Miguel,

On Thu, 24 Mar 2022 22:18:39 +0100, Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
> On Thu, Mar 24, 2022 at 6:10 PM Stephen Kitt <steve@sk2.org> wrote:
> > The i2c probe functions here don't use the id information provided in
> > their second argument, so the single-parameter i2c probe function
> > ("probe_new") can be used instead.
> >
> > This avoids scanning the identifier tables during probes.  
> 
> Thanks for the patch -- Andy submitted an equivalent one which I
> queued for -next some days ago.

Ah yes,
https://lkml.kernel.org/lkml/20220308151119.48412-3-andriy.shevchenko@linux.intel.com/

Thanks,

Stephen