[v1] media: mc: delete redundant code in __media_device_unregister_entity

[PATCH] media: mc: delete redundant code in __media_device_unregister_entity

Posted by Hangyu Hua 4 years, 2 months ago

media_gobj_destroy has already set graph_obj.mdev to NULL. There is no need to
set it again.

Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---
 drivers/media/mc/mc-device.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
index cf5e459b1d96..7727c619043e 100644
--- a/drivers/media/mc/mc-device.c
+++ b/drivers/media/mc/mc-device.c
@@ -605,7 +605,6 @@ static void __media_device_unregister_entity(struct media_entity *entity)
 
 	/* invoke entity_notify callbacks to handle entity removal?? */
 
-	entity->graph_obj.mdev = NULL;
 }
 
 /**
-- 
2.25.1

Re: [PATCH] media: mc: delete redundant code in __media_device_unregister_entity

Posted by Laurent Pinchart 4 years, 2 months ago

Hi Hangyu,

Thank you for the patch.

On Thu, Mar 24, 2022 at 06:27:52PM +0800, Hangyu Hua wrote:
> media_gobj_destroy has already set graph_obj.mdev to NULL. There is no need to
> set it again.
> 
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/mc/mc-device.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
> index cf5e459b1d96..7727c619043e 100644
> --- a/drivers/media/mc/mc-device.c
> +++ b/drivers/media/mc/mc-device.c
> @@ -605,7 +605,6 @@ static void __media_device_unregister_entity(struct media_entity *entity)
>  
>  	/* invoke entity_notify callbacks to handle entity removal?? */
>  
> -	entity->graph_obj.mdev = NULL;
>  }
>  
>  /**

-- 
Regards,

Laurent Pinchart