[PATCH net 0/2] ice: avoid sleeping/scheduling in atomic contexts

Alexander Lobakin posted 2 patches 4 years, 3 months ago
drivers/net/ethernet/intel/ice/ice.h      |  2 ++
drivers/net/ethernet/intel/ice/ice_idc.c  |  3 +++
drivers/net/ethernet/intel/ice/ice_main.c | 25 ++++++++++++++---------
3 files changed, 20 insertions(+), 10 deletions(-)
[PATCH net 0/2] ice: avoid sleeping/scheduling in atomic contexts
Posted by Alexander Lobakin 4 years, 3 months ago
The `ice_misc_intr() + ice_send_event_to_aux()` infamous pair failed
once again.
Fix yet another (hopefully last one) 'scheduling while atomic' splat
and finally plug the hole to gracefully return prematurely when
invoked in wrong context instead of panicking.

Alexander Lobakin (2):
  ice: fix 'scheduling while atomic' on aux critical err interrupt
  ice: don't allow to run ice_send_event_to_aux() in atomic ctx

 drivers/net/ethernet/intel/ice/ice.h      |  2 ++
 drivers/net/ethernet/intel/ice/ice_idc.c  |  3 +++
 drivers/net/ethernet/intel/ice/ice_main.c | 25 ++++++++++++++---------
 3 files changed, 20 insertions(+), 10 deletions(-)

-- 
Urgent fix, would like to make it directly through -net.
-- 
2.35.1
Re: [PATCH net 0/2] ice: avoid sleeping/scheduling in atomic contexts
Posted by Jakub Kicinski 4 years, 3 months ago
On Wed, 23 Mar 2022 13:43:51 +0100 Alexander Lobakin wrote:
> --
> Urgent fix, would like to make it directly through -net.

You may want to use three hyphens, two hyphens mean footer.
Email clients gray those out, it's easy to miss :)
Re: [PATCH net 0/2] ice: avoid sleeping/scheduling in atomic contexts
Posted by Alexander Lobakin 4 years, 3 months ago
From: Jakub Kicinski <kuba@kernel.org>
Date: Wed, 23 Mar 2022 10:40:05 -0700

> On Wed, 23 Mar 2022 13:43:51 +0100 Alexander Lobakin wrote:
> > --
> > Urgent fix, would like to make it directly through -net.
> 
> You may want to use three hyphens, two hyphens mean footer.
> Email clients gray those out, it's easy to miss :)

Good to know, thanks! :)

Al
Re: [PATCH net 0/2] ice: avoid sleeping/scheduling in atomic contexts
Posted by patchwork-bot+netdevbpf@kernel.org 4 years, 3 months ago
Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 23 Mar 2022 13:43:51 +0100 you wrote:
> The `ice_misc_intr() + ice_send_event_to_aux()` infamous pair failed
> once again.
> Fix yet another (hopefully last one) 'scheduling while atomic' splat
> and finally plug the hole to gracefully return prematurely when
> invoked in wrong context instead of panicking.
> 
> Alexander Lobakin (2):
>   ice: fix 'scheduling while atomic' on aux critical err interrupt
>   ice: don't allow to run ice_send_event_to_aux() in atomic ctx
> 
> [...]

Here is the summary with links:
  - [net,1/2] ice: fix 'scheduling while atomic' on aux critical err interrupt
    https://git.kernel.org/netdev/net/c/32d53c0aa3a7
  - [net,2/2] ice: don't allow to run ice_send_event_to_aux() in atomic ctx
    https://git.kernel.org/netdev/net/c/5a3156932da0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html