selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU

[PATCH v5 0/2] selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU

Posted by Shaopeng Tan 4 years, 3 months ago

Hello,

The aim of this series is to print a message to let users know a possible
cause of failure, if the result of MBM&CMT tests is failed on Intel CPU.
In order to detect Intel vendor, I extended AMD vendor detect function.

Difference from v4:
- Fixed the typos.
- Changed "get_vendor() != ARCH_AMD" to "get_vendor() == ARCH_INTEL".
- Reorder the declarations based on line length from longest to shortest.
https://lore.kernel.org/lkml/20220316055940.292550-1-tan.shaopeng@jp.fujitsu.com/ [PATCH v4]

This patch series is based on v5.17.

Shaopeng Tan (2):
  selftests/resctrl: Extend CPU vendor detection
  selftests/resctrl: Print a message if the result of MBM&CMT tests is
    failed on Intel CPU

 tools/testing/selftests/resctrl/cat_test.c    |  2 +-
 tools/testing/selftests/resctrl/resctrl.h     |  5 ++-
 .../testing/selftests/resctrl/resctrl_tests.c | 45 +++++++++++++------
 tools/testing/selftests/resctrl/resctrlfs.c   |  2 +-
 4 files changed, 37 insertions(+), 17 deletions(-)

-- 
2.27.0

Re: [PATCH v5 0/2] selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU

Posted by Shuah Khan 4 years, 2 months ago

On 3/23/22 2:09 AM, Shaopeng Tan wrote:
> Hello,
> 
> The aim of this series is to print a message to let users know a possible
> cause of failure, if the result of MBM&CMT tests is failed on Intel CPU.
> In order to detect Intel vendor, I extended AMD vendor detect function.
> 
> Difference from v4:
> - Fixed the typos.
> - Changed "get_vendor() != ARCH_AMD" to "get_vendor() == ARCH_INTEL".
> - Reorder the declarations based on line length from longest to shortest.
> https://lore.kernel.org/lkml/20220316055940.292550-1-tan.shaopeng@jp.fujitsu.com/ [PATCH v4]
> 
> This patch series is based on v5.17.
> 
> Shaopeng Tan (2):
>    selftests/resctrl: Extend CPU vendor detection
>    selftests/resctrl: Print a message if the result of MBM&CMT tests is
>      failed on Intel CPU
> 
>   tools/testing/selftests/resctrl/cat_test.c    |  2 +-
>   tools/testing/selftests/resctrl/resctrl.h     |  5 ++-
>   .../testing/selftests/resctrl/resctrl_tests.c | 45 +++++++++++++------
>   tools/testing/selftests/resctrl/resctrlfs.c   |  2 +-
>   4 files changed, 37 insertions(+), 17 deletions(-)
> 

I can queue this up for Linux 5.18-rc2. Thanks for fixing the error
path with clear messages for failures.

thanks,
-- Shuah

Re: [PATCH v5 0/2] selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU

Posted by Reinette Chatre 4 years, 1 month ago

Hi Shuah,

On 3/29/2022 8:37 AM, Shuah Khan wrote:
> On 3/23/22 2:09 AM, Shaopeng Tan wrote:
>> Hello,
>>
>> The aim of this series is to print a message to let users know a possible
>> cause of failure, if the result of MBM&CMT tests is failed on Intel CPU.
>> In order to detect Intel vendor, I extended AMD vendor detect function.
>>
>> Difference from v4:
>> - Fixed the typos.
>> - Changed "get_vendor() != ARCH_AMD" to "get_vendor() == ARCH_INTEL".
>> - Reorder the declarations based on line length from longest to shortest.
>> https://lore.kernel.org/lkml/20220316055940.292550-1-tan.shaopeng@jp.fujitsu.com/ [PATCH v4]
>>
>> This patch series is based on v5.17.
>>
>> Shaopeng Tan (2):
>>    selftests/resctrl: Extend CPU vendor detection
>>    selftests/resctrl: Print a message if the result of MBM&CMT tests is
>>      failed on Intel CPU
>>
>>   tools/testing/selftests/resctrl/cat_test.c    |  2 +-
>>   tools/testing/selftests/resctrl/resctrl.h     |  5 ++-
>>   .../testing/selftests/resctrl/resctrl_tests.c | 45 +++++++++++++------
>>   tools/testing/selftests/resctrl/resctrlfs.c   |  2 +-
>>   4 files changed, 37 insertions(+), 17 deletions(-)
>>
> 
> I can queue this up for Linux 5.18-rc2. Thanks for fixing the error
> path with clear messages for failures.

Is this perhaps still in your queue for consideration? I peeked at the
branches within the kselftest repo but could not find it merged yet.
If things are tightened for fixes it would be welcome as v5.19 material
also.

Thank you very much

Reinette

[1] git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git

Re: [PATCH v5 0/2] selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU

Posted by Shuah Khan 4 years, 1 month ago

On 4/25/22 3:19 PM, Reinette Chatre wrote:
> Hi Shuah,
> 
> On 3/29/2022 8:37 AM, Shuah Khan wrote:
>> On 3/23/22 2:09 AM, Shaopeng Tan wrote:
>>> Hello,
>>>
>>> The aim of this series is to print a message to let users know a possible
>>> cause of failure, if the result of MBM&CMT tests is failed on Intel CPU.
>>> In order to detect Intel vendor, I extended AMD vendor detect function.
>>>
>>> Difference from v4:
>>> - Fixed the typos.
>>> - Changed "get_vendor() != ARCH_AMD" to "get_vendor() == ARCH_INTEL".
>>> - Reorder the declarations based on line length from longest to shortest.
>>> https://lore.kernel.org/lkml/20220316055940.292550-1-tan.shaopeng@jp.fujitsu.com/ [PATCH v4]
>>>
>>> This patch series is based on v5.17.
>>>
>>> Shaopeng Tan (2):
>>>     selftests/resctrl: Extend CPU vendor detection
>>>     selftests/resctrl: Print a message if the result of MBM&CMT tests is
>>>       failed on Intel CPU
>>>
>>>    tools/testing/selftests/resctrl/cat_test.c    |  2 +-
>>>    tools/testing/selftests/resctrl/resctrl.h     |  5 ++-
>>>    .../testing/selftests/resctrl/resctrl_tests.c | 45 +++++++++++++------
>>>    tools/testing/selftests/resctrl/resctrlfs.c   |  2 +-
>>>    4 files changed, 37 insertions(+), 17 deletions(-)
>>>
>>
>> I can queue this up for Linux 5.18-rc2. Thanks for fixing the error
>> path with clear messages for failures.
> 
> Is this perhaps still in your queue for consideration? I peeked at the
> branches within the kselftest repo but could not find it merged yet.
> If things are tightened for fixes it would be welcome as v5.19 material
> also.
> 
> Thank you very much
> 

Thanks for the ping. The changes are a bit more extensive for a fix based
on my review comments. I queued these two in linux-kselftest next branch
for 5.19-rc1.

thanks,
-- Shuah

Re: [PATCH v5 0/2] selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU

Posted by Reinette Chatre 4 years, 1 month ago

On 4/25/2022 4:00 PM, Shuah Khan wrote:
> Thanks for the ping. The changes are a bit more extensive for a fix based
> on my review comments. I queued these two in linux-kselftest next branch
> for 5.19-rc1.

That's great. Thank you very much Shuah. Also thank you for picking up
Shaopeng's other resctrl kselftest series.

Reinette

RE: [PATCH v5 0/2] selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU

Posted by tan.shaopeng@fujitsu.com 4 years, 1 month ago

> On 4/25/2022 4:00 PM, Shuah Khan wrote:
> > Thanks for the ping. The changes are a bit more extensive for a fix
> > based on my review comments. I queued these two in linux-kselftest
> > next branch for 5.19-rc1.
> 
> That's great. Thank you very much Shuah. Also thank you for picking up
> Shaopeng's other resctrl kselftest series.

Thank you very much, Reinette and Shuah.

Best regards,
Tan Shaopeng