[PATCH -next] net: marvell: prestera: add missing destroy_workqueue() in prestera_module_init()

Yang Yingliang posted 1 patch 4 years, 3 months ago
drivers/net/ethernet/marvell/prestera/prestera_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[PATCH -next] net: marvell: prestera: add missing destroy_workqueue() in prestera_module_init()
Posted by Yang Yingliang 4 years, 3 months ago
Add the missing destroy_workqueue() before return from
prestera_module_init() in the error handling case.

Fixes: 4394fbcb78cf ("net: marvell: prestera: handle fib notifications")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/net/ethernet/marvell/prestera/prestera_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index 1402c7889e78..3952fdcc9240 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -1032,8 +1032,10 @@ static int __init prestera_module_init(void)
 		return -ENOMEM;
 
 	prestera_owq = alloc_ordered_workqueue("prestera_ordered", 0);
-	if (!prestera_owq)
+	if (!prestera_owq) {
+		destroy_workqueue(prestera_wq);
 		return -ENOMEM;
+	}
 
 	return 0;
 }
-- 
2.25.1
Re: [PATCH -next] net: marvell: prestera: add missing destroy_workqueue() in prestera_module_init()
Posted by patchwork-bot+netdevbpf@kernel.org 4 years, 3 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 22 Mar 2022 17:02:36 +0800 you wrote:
> Add the missing destroy_workqueue() before return from
> prestera_module_init() in the error handling case.
> 
> Fixes: 4394fbcb78cf ("net: marvell: prestera: handle fib notifications")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/net/ethernet/marvell/prestera/prestera_main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [-next] net: marvell: prestera: add missing destroy_workqueue() in prestera_module_init()
    https://git.kernel.org/netdev/net-next/c/4a6806cfcbca

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html