[PATCH] nvme-pci: make use_threaded_interrupts mod-param read-only

Xin Hao posted 1 patch 4 years, 3 months ago
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] nvme-pci: make use_threaded_interrupts mod-param read-only
Posted by Xin Hao 4 years, 3 months ago
When I execute "insmod nvme.ko use_threaded_interrupts=1",
I find it difficult to determine whether it is successful
or not, So I want to add read-only parameter to
'/sys/module/nvme/parameters/use_threaded_interrupts',
When insmoded successfully.
    # cat /sys/module/nvme/parameters/use_threaded_interrupts
    # 1

Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
---
 drivers/nvme/host/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 6a99ed680915..27cd20130021 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -44,7 +44,7 @@
 #define NVME_MAX_SEGS	127

 static int use_threaded_interrupts;
-module_param(use_threaded_interrupts, int, 0);
+module_param(use_threaded_interrupts, int, 0444);

 static bool use_cmb_sqes = true;
 module_param(use_cmb_sqes, bool, 0444);
--
2.31.0
Re: [PATCH] nvme-pci: make use_threaded_interrupts mod-param read-only
Posted by Christoph Hellwig 4 years, 3 months ago
Thanks,

applied to nvme-5.18.