hi,
Andrii reported that backtraces from kprobe_multi program attached
as return probes are not complete and showing just initial entry [1].

Sending the fix together with bpf_get_func_ip inline revert, which is
no longer suitable.

thanks,
jirka


---
[1] https://lore.kernel.org/bpf/CAEf4BzZDDqK24rSKwXNp7XL3ErGD4bZa1M6c_c4EvDSt3jrZcg@mail.gmail.com/T/#m8d1301c0ea0892ddf9dc6fba57a57b8cf11b8c51

Jiri Olsa (2):
      Revert "bpf: Add support to inline bpf_get_func_ip helper on x86"
      bpf: Fix kprobe_multi return probe backtrace

 kernel/bpf/verifier.c    | 21 +--------------------
 kernel/trace/bpf_trace.c | 68 +++++++++++++++++++++++++++++++++++++-------------------------------
 2 files changed, 38 insertions(+), 51 deletions(-)

Hello:

This series was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Mon, 21 Mar 2022 08:01:11 +0100 you wrote:
> hi,
> Andrii reported that backtraces from kprobe_multi program attached
> as return probes are not complete and showing just initial entry [1].
> 
> Sending the fix together with bpf_get_func_ip inline revert, which is
> no longer suitable.
> 
> [...]

Here is the summary with links:
  - [bpf-next,1/2] Revert "bpf: Add support to inline bpf_get_func_ip helper on x86"
    https://git.kernel.org/bpf/bpf-next/c/f705ec764b34
  - [bpf-next,2/2] bpf: Fix kprobe_multi return probe backtrace
    https://git.kernel.org/bpf/bpf-next/c/f70986902c86

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

On Mon, 21 Mar 2022 08:01:11 +0100
Jiri Olsa <jolsa@kernel.org> wrote:

> hi,
> Andrii reported that backtraces from kprobe_multi program attached
> as return probes are not complete and showing just initial entry [1].
> 
> Sending the fix together with bpf_get_func_ip inline revert, which is
> no longer suitable.

OK, this series looks good to me.

Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you,

> 
> thanks,
> jirka
> 
> 
> ---
> [1] https://lore.kernel.org/bpf/CAEf4BzZDDqK24rSKwXNp7XL3ErGD4bZa1M6c_c4EvDSt3jrZcg@mail.gmail.com/T/#m8d1301c0ea0892ddf9dc6fba57a57b8cf11b8c51
> 
> Jiri Olsa (2):
>       Revert "bpf: Add support to inline bpf_get_func_ip helper on x86"
>       bpf: Fix kprobe_multi return probe backtrace
> 
>  kernel/bpf/verifier.c    | 21 +--------------------
>  kernel/trace/bpf_trace.c | 68 +++++++++++++++++++++++++++++++++++++-------------------------------
>  2 files changed, 38 insertions(+), 51 deletions(-)


-- 
Masami Hiramatsu <mhiramat@kernel.org>