[v4] Add driver nodes for MT8192 SoC

[PATCH v4 19/22] arm64: dts: mt8192: Add the mmsys reset bit to reset the dsi0

Posted by Allen-KH Cheng 2 years, 6 months ago

Reset the DSI hardware is needed to prevent different settings between
the bootloader and the kernel.

Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
 include/dt-bindings/reset/mt8192-resets.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/dt-bindings/reset/mt8192-resets.h b/include/dt-bindings/reset/mt8192-resets.h
index be9a7ca245b9..764ca9910fa9 100644
--- a/include/dt-bindings/reset/mt8192-resets.h
+++ b/include/dt-bindings/reset/mt8192-resets.h
@@ -27,4 +27,7 @@
 
 #define MT8192_TOPRGU_SW_RST_NUM				23
 
+/* MMSYS resets */
+#define MT8192_MMSYS_SW0_RST_B_DISP_DSI0			15
+
 #endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT8192 */
-- 
2.18.0

Re: [PATCH v4 19/22] arm64: dts: mt8192: Add the mmsys reset bit to reset the dsi0

Posted by Rob Herring 2 years, 6 months ago

On Fri, 18 Mar 2022 22:45:31 +0800, Allen-KH Cheng wrote:
> Reset the DSI hardware is needed to prevent different settings between
> the bootloader and the kernel.
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
>  include/dt-bindings/reset/mt8192-resets.h | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH v4 19/22] arm64: dts: mt8192: Add the mmsys reset bit to reset the dsi0

Posted by Nícolas F. R. A. Prado 2 years, 6 months ago

On Fri, Mar 18, 2022 at 10:45:31PM +0800, Allen-KH Cheng wrote:
> Reset the DSI hardware is needed to prevent different settings between
> the bootloader and the kernel.
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

> ---
>  include/dt-bindings/reset/mt8192-resets.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/reset/mt8192-resets.h b/include/dt-bindings/reset/mt8192-resets.h
> index be9a7ca245b9..764ca9910fa9 100644
> --- a/include/dt-bindings/reset/mt8192-resets.h
> +++ b/include/dt-bindings/reset/mt8192-resets.h
> @@ -27,4 +27,7 @@
>  
>  #define MT8192_TOPRGU_SW_RST_NUM				23
>  
> +/* MMSYS resets */
> +#define MT8192_MMSYS_SW0_RST_B_DISP_DSI0			15
> +
>  #endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT8192 */
> -- 
> 2.18.0
> 
>

Re: [PATCH v4 19/22] arm64: dts: mt8192: Add the mmsys reset bit to reset the dsi0

Posted by AngeloGioacchino Del Regno 2 years, 6 months ago

Il 18/03/22 15:45, Allen-KH Cheng ha scritto:
> Reset the DSI hardware is needed to prevent different settings between
> the bootloader and the kernel.
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Note: since there were some mtk-mmsys.c updates in the meanwhile, this patch
requires [1] to be merged in order to work correctly.

Aside from that:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


[1]: 
https://patchwork.kernel.org/project/linux-mediatek/patch/20220323091932.10648-1-angelogioacchino.delregno@collabora.com/

> ---
>   include/dt-bindings/reset/mt8192-resets.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/reset/mt8192-resets.h b/include/dt-bindings/reset/mt8192-resets.h
> index be9a7ca245b9..764ca9910fa9 100644
> --- a/include/dt-bindings/reset/mt8192-resets.h
> +++ b/include/dt-bindings/reset/mt8192-resets.h
> @@ -27,4 +27,7 @@
>   
>   #define MT8192_TOPRGU_SW_RST_NUM				23
>   
> +/* MMSYS resets */
> +#define MT8192_MMSYS_SW0_RST_B_DISP_DSI0			15
> +
>   #endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT8192 */

Re: [PATCH v4 19/22] arm64: dts: mt8192: Add the mmsys reset bit to reset the dsi0

Posted by Matthias Brugger 2 years, 5 months ago


On 18/03/2022 15:45, Allen-KH Cheng wrote:
> Reset the DSI hardware is needed to prevent different settings between
> the bootloader and the kernel.
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>

Applied thanks

> ---
>   include/dt-bindings/reset/mt8192-resets.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/reset/mt8192-resets.h b/include/dt-bindings/reset/mt8192-resets.h
> index be9a7ca245b9..764ca9910fa9 100644
> --- a/include/dt-bindings/reset/mt8192-resets.h
> +++ b/include/dt-bindings/reset/mt8192-resets.h
> @@ -27,4 +27,7 @@
>   
>   #define MT8192_TOPRGU_SW_RST_NUM				23
>   
> +/* MMSYS resets */
> +#define MT8192_MMSYS_SW0_RST_B_DISP_DSI0			15
> +
>   #endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT8192 */