[PATCH v2] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks

Miaoqian Lin posted 1 patch 4 years, 3 months ago
drivers/phy/ti/phy-omap-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks
Posted by Miaoqian Lin 4 years, 3 months ago
The corresponding API for clk_prepare_enable is clk_disable_unprepare.
Make sure that the clock is unprepared on exit by changing clk_disable
to clk_disable_unprepare.

Fixes: ed31ee7cf1fe ("phy: ti: usb2: Fix logic on -EPROBE_DEFER")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
changes in v2:
- fix typo in commit message.
---
 drivers/phy/ti/phy-omap-usb2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c
index 3a505fe5715a..31a775877f6e 100644
--- a/drivers/phy/ti/phy-omap-usb2.c
+++ b/drivers/phy/ti/phy-omap-usb2.c
@@ -215,7 +215,7 @@ static int omap_usb2_enable_clocks(struct omap_usb *phy)
 	return 0;
 
 err1:
-	clk_disable(phy->wkupclk);
+	clk_disable_unprepare(phy->wkupclk);
 
 err0:
 	return ret;
-- 
2.17.1
Re: [PATCH v2] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks
Posted by Vinod Koul 4 years, 2 months ago
On 18-03-22, 10:57, Miaoqian Lin wrote:
> The corresponding API for clk_prepare_enable is clk_disable_unprepare.
> Make sure that the clock is unprepared on exit by changing clk_disable
> to clk_disable_unprepare.

Applied, thanks

-- 
~Vinod