perf parse-events: Ignore case in topdown.slots check

[PATCH] perf parse-events: Ignore case in topdown.slots check

Posted by Ian Rogers 4 years, 3 months ago

An issue with icelakex metrics:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json?h=perf/core&id=65eab2bc7dab326ee892ec5a4c749470b368b51a#n48
That causes the slots not to be first.

Fixes: 94dbfd6781a0 ("perf parse-events: Architecture specific leader override")
Reported-by: Caleb Biggers <caleb.biggers@intel.com>
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/arch/x86/util/evlist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/arch/x86/util/evlist.c b/tools/perf/arch/x86/util/evlist.c
index f924246eff78..8d9b55959256 100644
--- a/tools/perf/arch/x86/util/evlist.c
+++ b/tools/perf/arch/x86/util/evlist.c
@@ -29,7 +29,7 @@ struct evsel *arch_evlist__leader(struct list_head *list)
 
 	__evlist__for_each_entry(list, evsel) {
 		if (evsel->pmu_name && !strcmp(evsel->pmu_name, "cpu") &&
-			evsel->name && strstr(evsel->name, "slots"))
+			evsel->name && strcasestr(evsel->name, "slots"))
 			return evsel;
 	}
 	return first;
-- 
2.35.1.894.gb6a874cedc-goog

Re: [PATCH] perf parse-events: Ignore case in topdown.slots check

Posted by Arnaldo Carvalho de Melo 4 years, 3 months ago

Em Thu, Mar 17, 2022 at 03:43:09PM -0700, Ian Rogers escreveu:
> An issue with icelakex metrics:
> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json?h=perf/core&id=65eab2bc7dab326ee892ec5a4c749470b368b51a#n48
> That causes the slots not to be first.

Thanks, applied.

- Arnaldo

 
> Fixes: 94dbfd6781a0 ("perf parse-events: Architecture specific leader override")
> Reported-by: Caleb Biggers <caleb.biggers@intel.com>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/arch/x86/util/evlist.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/arch/x86/util/evlist.c b/tools/perf/arch/x86/util/evlist.c
> index f924246eff78..8d9b55959256 100644
> --- a/tools/perf/arch/x86/util/evlist.c
> +++ b/tools/perf/arch/x86/util/evlist.c
> @@ -29,7 +29,7 @@ struct evsel *arch_evlist__leader(struct list_head *list)
>  
>  	__evlist__for_each_entry(list, evsel) {
>  		if (evsel->pmu_name && !strcmp(evsel->pmu_name, "cpu") &&
> -			evsel->name && strstr(evsel->name, "slots"))
> +			evsel->name && strcasestr(evsel->name, "slots"))
>  			return evsel;
>  	}
>  	return first;
> -- 
> 2.35.1.894.gb6a874cedc-goog

-- 

- Arnaldo