MIPS: ingenic: correct unit node address

[PATCH] MIPS: ingenic: correct unit node address

Posted by Krzysztof Kozlowski 4 years, 3 months ago

Unit node addresses should not have leading 0x:

  Warning (unit_address_format): /nemc@13410000/efuse@d0/eth-mac-addr@0x22: unit name should not have leading "0x"

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
index 3f9ea47a10cd..b998301f179c 100644
--- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
+++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
@@ -510,7 +510,7 @@ efuse: efuse@d0 {
 			#address-cells = <1>;
 			#size-cells = <1>;
 
-			eth0_addr: eth-mac-addr@0x22 {
+			eth0_addr: eth-mac-addr@22 {
 				reg = <0x22 0x6>;
 			};
 		};
-- 
2.32.0

Re: [PATCH] MIPS: ingenic: correct unit node address

Posted by Paul Cercueil 4 years, 3 months ago

Hi,

Le jeu., mars 17 2022 at 12:52:59 +0100, Krzysztof Kozlowski 
<krzysztof.kozlowski@canonical.com> a écrit :
> Unit node addresses should not have leading 0x:
> 
>   Warning (unit_address_format): 
> /nemc@13410000/efuse@d0/eth-mac-addr@0x22: unit name should not have 
> leading "0x"
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Reviewed-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> ---
>  arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi 
> b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index 3f9ea47a10cd..b998301f179c 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -510,7 +510,7 @@ efuse: efuse@d0 {
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> 
> -			eth0_addr: eth-mac-addr@0x22 {
> +			eth0_addr: eth-mac-addr@22 {
>  				reg = <0x22 0x6>;
>  			};
>  		};
> --
> 2.32.0
>

Re: [PATCH] MIPS: ingenic: correct unit node address

Posted by Thomas Bogendoerfer 4 years, 3 months ago

On Thu, Mar 17, 2022 at 12:52:59PM +0100, Krzysztof Kozlowski wrote:
> Unit node addresses should not have leading 0x:
> 
>   Warning (unit_address_format): /nemc@13410000/efuse@d0/eth-mac-addr@0x22: unit name should not have leading "0x"
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index 3f9ea47a10cd..b998301f179c 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -510,7 +510,7 @@ efuse: efuse@d0 {
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  
> -			eth0_addr: eth-mac-addr@0x22 {
> +			eth0_addr: eth-mac-addr@22 {
>  				reg = <0x22 0x6>;
>  			};
>  		};
> -- 
> 2.32.0

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]