pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS

[PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS

Posted by Jonathan Neuschäfer 4 years, 3 months ago

CONFIG_GENERIC_PINCTRL_GROUPS must be selected in order for
struct group_desc to be defined in pinctrl/core.h.

Add the missing select line to CONFIG_PINCTRL_WPCM450.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 drivers/pinctrl/nuvoton/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
index 6a3c6f2a73f2d..b48d32912bef1 100644
--- a/drivers/pinctrl/nuvoton/Kconfig
+++ b/drivers/pinctrl/nuvoton/Kconfig
@@ -6,6 +6,7 @@ config PINCTRL_WPCM450
 	select PINMUX
 	select PINCONF
 	select GENERIC_PINCONF
+	select GENERIC_PINCTRL_GROUPS
 	select GPIOLIB
 	select GPIO_GENERIC
 	select GPIOLIB_IRQCHIP
--
2.35.1

Re: [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS

Posted by Jonathan Neuschäfer 4 years, 3 months ago

On Thu, Mar 17, 2022 at 12:44:12PM +0100, Jonathan Neuschäfer wrote:
> CONFIG_GENERIC_PINCTRL_GROUPS must be selected in order for
> struct group_desc to be defined in pinctrl/core.h.
> 
> Add the missing select line to CONFIG_PINCTRL_WPCM450.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Ah well, I forgot

	Fixes: a1d1e0e3d80a8 ("pinctrl: nuvoton: Add driver for WPCM450")

which would be appropriate here.


> ---
>  drivers/pinctrl/nuvoton/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
> index 6a3c6f2a73f2d..b48d32912bef1 100644
> --- a/drivers/pinctrl/nuvoton/Kconfig
> +++ b/drivers/pinctrl/nuvoton/Kconfig
> @@ -6,6 +6,7 @@ config PINCTRL_WPCM450
>  	select PINMUX
>  	select PINCONF
>  	select GENERIC_PINCONF
> +	select GENERIC_PINCTRL_GROUPS
>  	select GPIOLIB
>  	select GPIO_GENERIC
>  	select GPIOLIB_IRQCHIP
> --
> 2.35.1
>

Re: [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS

Posted by Linus Walleij 4 years, 3 months ago

On Thu, Mar 17, 2022 at 12:44 PM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:

> CONFIG_GENERIC_PINCTRL_GROUPS must be selected in order for
> struct group_desc to be defined in pinctrl/core.h.
>
> Add the missing select line to CONFIG_PINCTRL_WPCM450.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Patch applied with the Fixes: tag!

Thanks!
Linus Walleij