locking/refcount: Use REFCOUNT_WARN() to simplify code

[PATCH] locking/refcount: Use REFCOUNT_WARN() to simplify code

Posted by Zhen Lei 4 years, 3 months ago

To avoid the check "new > val" appears twice, and make the style
consistent with that in refcount_warn_saturate().

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 lib/refcount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/refcount.c b/lib/refcount.c
index a207a8f22b3ca35..d36aa3fa728f53b 100644
--- a/lib/refcount.c
+++ b/lib/refcount.c
@@ -84,7 +84,7 @@ bool refcount_dec_not_one(refcount_t *r)
 
 		new = val - 1;
 		if (new > val) {
-			WARN_ONCE(new > val, "refcount_t: underflow; use-after-free.\n");
+			REFCOUNT_WARN("underflow; use-after-free");
 			return true;
 		}
 
-- 
2.25.1

Re: [PATCH] locking/refcount: Use REFCOUNT_WARN() to simplify code

Posted by Will Deacon 4 years, 2 months ago

On Wed, Mar 16, 2022 at 08:51:14PM +0800, Zhen Lei wrote:
> To avoid the check "new > val" appears twice, and make the style
> consistent with that in refcount_warn_saturate().
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  lib/refcount.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/refcount.c b/lib/refcount.c
> index a207a8f22b3ca35..d36aa3fa728f53b 100644
> --- a/lib/refcount.c
> +++ b/lib/refcount.c
> @@ -84,7 +84,7 @@ bool refcount_dec_not_one(refcount_t *r)
>  
>  		new = val - 1;
>  		if (new > val) {
> -			WARN_ONCE(new > val, "refcount_t: underflow; use-after-free.\n");
> +			REFCOUNT_WARN("underflow; use-after-free");
>  			return true;
>  		}

Acked-by: Will Deacon <will@kernel.org>

Will

Re: [PATCH] locking/refcount: Use REFCOUNT_WARN() to simplify code

Posted by Leizhen (ThunderTown) 3 years, 7 months ago


On 2022/4/4 17:31, Will Deacon wrote:
> On Wed, Mar 16, 2022 at 08:51:14PM +0800, Zhen Lei wrote:
>> To avoid the check "new > val" appears twice, and make the style
>> consistent with that in refcount_warn_saturate().
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>  lib/refcount.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/refcount.c b/lib/refcount.c
>> index a207a8f22b3ca35..d36aa3fa728f53b 100644
>> --- a/lib/refcount.c
>> +++ b/lib/refcount.c
>> @@ -84,7 +84,7 @@ bool refcount_dec_not_one(refcount_t *r)
>>  
>>  		new = val - 1;
>>  		if (new > val) {
>> -			WARN_ONCE(new > val, "refcount_t: underflow; use-after-free.\n");
>> +			REFCOUNT_WARN("underflow; use-after-free");
>>  			return true;
>>  		}
> 
> Acked-by: Will Deacon <will@kernel.org>

Can anyone pick up this patch? It seems to have been forgotten.

> 
> Will
> .
> 

-- 
Regards,
  Zhen Lei