mm: proc: remove redundant page validation of pte_page

[PATCH] mm: proc: remove redundant page validation of pte_page

Posted by Xianting Tian 4 years, 3 months ago

pte_page() always returns a valid page, so remove the redundant
page validation, as we did in many other places.

Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
 fs/proc/task_mmu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index f46060eb9..a843d13e2 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -1873,8 +1873,6 @@ static int gather_hugetlb_stats(pte_t *pte, unsigned long hmask,
 		return 0;
 
 	page = pte_page(huge_pte);
-	if (!page)
-		return 0;
 
 	md = walk->private;
 	gather_stats(page, md, pte_dirty(huge_pte), 1);
-- 
2.17.1

Re: [PATCH] mm: proc: remove redundant page validation of pte_page

Posted by Chaitanya Kulkarni 4 years, 3 months ago

On 3/15/22 19:59, Xianting Tian wrote:
> pte_page() always returns a valid page, so remove the redundant
> page validation, as we did in many other places.
> 
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
> ---


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck