[PATCH] mailbox: imx: Fix duplicate field initialization in imx

Wan Jiabing posted 1 patch 4 years, 3 months ago
drivers/mailbox/imx-mailbox.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] mailbox: imx: Fix duplicate field initialization in imx
Posted by Wan Jiabing 4 years, 3 months ago
Fix the following coccicheck warning:
./drivers/mailbox/imx-mailbox.c:884:51-52: rxdb: first occurrence line
887, second occurrence line 889

Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/mailbox/imx-mailbox.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
index e88f544a1548..df8a785be324 100644
--- a/drivers/mailbox/imx-mailbox.c
+++ b/drivers/mailbox/imx-mailbox.c
@@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = {
 	.rx	= imx_mu_generic_rx,
 	.rxdb	= imx_mu_generic_rxdb,
 	.init	= imx_mu_init_generic,
-	.rxdb	= imx_mu_generic_rxdb,
 	.type	= IMX_MU_V2,
 	.xTR	= 0x200,
 	.xRR	= 0x280,
-- 
2.35.1
RE: [PATCH] mailbox: imx: Fix duplicate field initialization in imx
Posted by Peng Fan 4 years, 3 months ago
> Subject: [PATCH] mailbox: imx: Fix duplicate field initialization in imx
> 
> Fix the following coccicheck warning:
> ./drivers/mailbox/imx-mailbox.c:884:51-52: rxdb: first occurrence line 887,
> second occurrence line 889
> 
> Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  drivers/mailbox/imx-mailbox.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index e88f544a1548..df8a785be324 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp
> = {
>  	.rx	= imx_mu_generic_rx,
>  	.rxdb	= imx_mu_generic_rxdb,
>  	.init	= imx_mu_init_generic,
> -	.rxdb	= imx_mu_generic_rxdb,
>  	.type	= IMX_MU_V2,
>  	.xTR	= 0x200,
>  	.xRR	= 0x280,
> --
> 2.35.1
Re: [PATCH] mailbox: imx: Fix duplicate field initialization in imx
Posted by Wan Jiabing 4 years, 1 month ago
On Wed, Mar 16, 2022 at 02:03:49AM +0000, Peng Fan wrote:
> > Subject: [PATCH] mailbox: imx: Fix duplicate field initialization in imx
> > 
> > Fix the following coccicheck warning:
> > ./drivers/mailbox/imx-mailbox.c:884:51-52: rxdb: first occurrence line 887,
> > second occurrence line 889
> > 
> > Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
> > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> 
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> 
> > ---
> >  drivers/mailbox/imx-mailbox.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> > index e88f544a1548..df8a785be324 100644
> > --- a/drivers/mailbox/imx-mailbox.c
> > +++ b/drivers/mailbox/imx-mailbox.c
> > @@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp
> > = {
> >  	.rx	= imx_mu_generic_rx,
> >  	.rxdb	= imx_mu_generic_rxdb,
> >  	.init	= imx_mu_init_generic,
> > -	.rxdb	= imx_mu_generic_rxdb,
> >  	.type	= IMX_MU_V2,
> >  	.xTR	= 0x200,
> >  	.xRR	= 0x280,
> > --
> > 2.35.1
> 

Hi, all

I notice the status of this patch hasn't been updated for
a long time.

Could someone pick it up to avoid warning again?

[0] https://lore.kernel.org/all/20220403145304.685443-1-trix@redhat.com/

Thanks,
Wan Jiabing