[PATCH] ARM: fix compilation error when BPF_SYSCALL is disabled

Emmanuel Gil Peyrot posted 1 patch 4 years, 3 months ago
arch/arm/kernel/spectre.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] ARM: fix compilation error when BPF_SYSCALL is disabled
Posted by Emmanuel Gil Peyrot 4 years, 3 months ago
It was missing a semicolon.

Fixes build error introduced in
25875aa71dfefd1959f07e626c4d285b88b27ac2.

Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
---
 arch/arm/kernel/spectre.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/kernel/spectre.c b/arch/arm/kernel/spectre.c
index e7fea962d632..0dcefc36fb7a 100644
--- a/arch/arm/kernel/spectre.c
+++ b/arch/arm/kernel/spectre.c
@@ -10,7 +10,7 @@ static bool _unprivileged_ebpf_enabled(void)
 #ifdef CONFIG_BPF_SYSCALL
 	return !sysctl_unprivileged_bpf_disabled;
 #else
-	return false
+	return false;
 #endif
 }
 
-- 
2.35.1
Re: [PATCH] ARM: fix compilation error when BPF_SYSCALL is disabled
Posted by Nathan Chancellor 4 years, 3 months ago
On Tue, Mar 08, 2022 at 08:18:20PM +0100, Emmanuel Gil Peyrot wrote:
> It was missing a semicolon.
> 
> Fixes build error introduced in
> 25875aa71dfefd1959f07e626c4d285b88b27ac2.
> 
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>

Our CI just went red from this as well:

https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953090927
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953124502
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953090534
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953086304
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953050829

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

Linus, would it be possible for you apply this directly?

> ---
>  arch/arm/kernel/spectre.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/spectre.c b/arch/arm/kernel/spectre.c
> index e7fea962d632..0dcefc36fb7a 100644
> --- a/arch/arm/kernel/spectre.c
> +++ b/arch/arm/kernel/spectre.c
> @@ -10,7 +10,7 @@ static bool _unprivileged_ebpf_enabled(void)
>  #ifdef CONFIG_BPF_SYSCALL
>  	return !sysctl_unprivileged_bpf_disabled;
>  #else
> -	return false
> +	return false;
>  #endif
>  }
>  
> -- 
> 2.35.1
> 
>
Re: [PATCH] ARM: fix compilation error when BPF_SYSCALL is disabled
Posted by Linus Torvalds 4 years, 3 months ago
On Tue, Mar 8, 2022 at 12:39 PM Nathan Chancellor <nathan@kernel.org> wrote:
>
> Linus, would it be possible for you apply this directly?

Done.

              Linus