[v1] net: phy: lan87xx: use genphy_read_master_slave function

[PATCH net-next 0/2] net: phy: lan87xx: use genphy_read_master_slave function

Posted by Arun Ramadoss 4 years, 3 months ago

LAN87xx T1 Phy has the same register field as gigabit phy for reading the
master slave configuration. But the genphy_read_master_slave function has a
check of gigabit phy. So refactored the function in such a way, moved the speed
check to the genphy_read_status function. Analyzed the nxp-tja11xx function for
refactoring, but the register for configuring master/slave is nxp specific
which is not extended phy register.
And analyzed the reusing genphy_setup_master_slave, but for LAN87xx
MASTER_ENABLE is always 1 and Preferred state is always 0. So, I didn't try to
change it.

Arun Ramadoss (2):
  net: phy: exported the genphy_read_master_slave function
  net: phy: lan87xx: use genphy_read_master_slave in read_status

 drivers/net/phy/microchip_t1.c | 30 +-----------------------------
 drivers/net/phy/phy_device.c   | 19 +++++++++----------
 include/linux/phy.h            |  1 +
 3 files changed, 11 insertions(+), 39 deletions(-)


base-commit: 57d29a2935c9aab0aaef6264bf6a58aad3859e7c
-- 
2.33.0

Re: [PATCH net-next 0/2] net: phy: lan87xx: use genphy_read_master_slave function

Posted by patchwork-bot+netdevbpf@kernel.org 4 years, 3 months ago

Hello:

This series was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Mon, 7 Mar 2022 21:45:13 +0530 you wrote:
> LAN87xx T1 Phy has the same register field as gigabit phy for reading the
> master slave configuration. But the genphy_read_master_slave function has a
> check of gigabit phy. So refactored the function in such a way, moved the speed
> check to the genphy_read_status function. Analyzed the nxp-tja11xx function for
> refactoring, but the register for configuring master/slave is nxp specific
> which is not extended phy register.
> And analyzed the reusing genphy_setup_master_slave, but for LAN87xx
> MASTER_ENABLE is always 1 and Preferred state is always 0. So, I didn't try to
> change it.
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: phy: exported the genphy_read_master_slave function
    https://git.kernel.org/netdev/net-next/c/64807c232151
  - [net-next,2/2] net: phy: lan87xx: use genphy_read_master_slave in read_status
    https://git.kernel.org/netdev/net-next/c/f1f3a674261e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html