drivers/clk/samsung/clk-exynos-clkout.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
Use of_device_get_match_data() to simplify the code.
v1->v2:
Add a judgment for returning variant to NULL
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
---
drivers/clk/samsung/clk-exynos-clkout.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c
index e6d6cbf8c4e6..273f77d54dab 100644
--- a/drivers/clk/samsung/clk-exynos-clkout.c
+++ b/drivers/clk/samsung/clk-exynos-clkout.c
@@ -81,19 +81,17 @@ MODULE_DEVICE_TABLE(of, exynos_clkout_ids);
static int exynos_clkout_match_parent_dev(struct device *dev, u32 *mux_mask)
{
const struct exynos_clkout_variant *variant;
- const struct of_device_id *match;
if (!dev->parent) {
dev_err(dev, "not instantiated from MFD\n");
return -EINVAL;
}
- match = of_match_device(exynos_clkout_ids, dev->parent);
- if (!match) {
+ variant = of_device_get_match_data(dev->parent);
+ if (!variant) {
dev_err(dev, "cannot match parent device\n");
return -EINVAL;
}
- variant = match->data;
*mux_mask = variant->mux_mask;
--
2.25.1
On Mon, 7 Mar 2022 03:35:46 +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
>
> Use of_device_get_match_data() to simplify the code.
>
> v1->v2:
> Add a judgment for returning variant to NULL
>
> [...]
Applied, thanks!
[1/1] clk/samsung: Use of_device_get_match_data()
https://git.kernel.org/krzk/linux/c/777aaf3d1daf793461269b49c063aca1cee06a44
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
On 07/03/2022 04:35, cgel.zte@gmail.com wrote: > From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn> > > Use of_device_get_match_data() to simplify the code. > > v1->v2: > Add a judgment for returning variant to NULL Changelog goes after ---, not inside the commit message. With commit fix above: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
© 2016 - 2026 Red Hat, Inc.