[PATCH] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties

Rob Herring posted 1 patch 4 years, 3 months ago
arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties
Posted by Rob Herring 4 years, 3 months ago
A label reference without brackets is a path string, not a phandle as
intended. Add the missing brackets.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
index c4dd2a6b4836..f81ce3240342 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
@@ -770,8 +770,8 @@ &sdio0 {
 	sd-uhs-sdr104;
 
 	/* Power supply */
-	vqmmc-supply = &vcc1v8_s3;	/* IO line */
-	vmmc-supply = &vcc_sdio;	/* card's power */
+	vqmmc-supply = <&vcc1v8_s3>;	/* IO line */
+	vmmc-supply = <&vcc_sdio>;	/* card's power */
 
 	#address-cells = <1>;
 	#size-cells = <0>;
-- 
2.32.0
Re: [PATCH] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties
Posted by Heiko Stuebner 4 years, 3 months ago
On Fri, 4 Mar 2022 14:25:58 -0600, Rob Herring wrote:
> A label reference without brackets is a path string, not a phandle as
> intended. Add the missing brackets.

Applied, thanks!

[1/1] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties
      commit: 37cbd3c522869247ed4525b5042ff4c6a276c813

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>