[PATCH] arm64: dts: renesas: falcon-cpu: Use INTC_EX for SN65DSI86

Kieran Bingham posted 1 patch 4 years, 3 months ago
There is a newer version of this series
arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] arm64: dts: renesas: falcon-cpu: Use INTC_EX for SN65DSI86
Posted by Kieran Bingham 4 years, 3 months ago
The INTC block is a better choice for handling the interrupts on the V3U
as the INTC will always be powered, while the GPIO block may be
de-clocked if not in use. Further more, it may be likely to have a lower
power consumption as it does not need to drive the pins.

Switch the interrupt parent and interrupts definition from gpio1 to
intc_ex, allowing the PFC to configure the pin muxing accordingly.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
 arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
index 6af3f4f4f268..b7254a0f08b6 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
@@ -198,8 +198,8 @@ bridge@2c {
 		clocks = <&sn65dsi86_refclk>;
 		clock-names = "refclk";
 
-		interrupt-parent = <&gpio1>;
-		interrupts = <24 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-parent = <&intc_ex>;
+		interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
 
 		vccio-supply = <&reg_1p8v>;
 		vpll-supply = <&reg_1p8v>;
-- 
2.32.0
Re: [PATCH] arm64: dts: renesas: falcon-cpu: Use INTC_EX for SN65DSI86
Posted by Geert Uytterhoeven 4 years, 3 months ago
Hi Kieran,

On Fri, Mar 4, 2022 at 12:41 PM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> The INTC block is a better choice for handling the interrupts on the V3U
> as the INTC will always be powered, while the GPIO block may be
> de-clocked if not in use. Further more, it may be likely to have a lower
> power consumption as it does not need to drive the pins.
>
> Switch the interrupt parent and interrupts definition from gpio1 to
> intc_ex, allowing the PFC to configure the pin muxing accordingly.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
> @@ -198,8 +198,8 @@ bridge@2c {
>                 clocks = <&sn65dsi86_refclk>;
>                 clock-names = "refclk";
>
> -               interrupt-parent = <&gpio1>;
> -               interrupts = <24 IRQ_TYPE_LEVEL_HIGH>;
> +               interrupt-parent = <&intc_ex>;
> +               interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
>
>                 vccio-supply = <&reg_1p8v>;
>                 vpll-supply = <&reg_1p8v>;

The above is correct, but you forgot to configure pin control for the
irq0 pin.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds