[PATCH v7 0/6] Raspberry Pi Sense HAT driver

Charles Mirabile posted 6 patches 4 years, 3 months ago
There is a newer version of this series
.../raspberrypi,sensehat-display.yaml         |  27 +++
.../input/raspberrypi,sensehat-joystick.yaml  |  33 +++
.../bindings/mfd/raspberrypi,sensehat.yaml    |  69 +++++++
MAINTAINERS                                   |  11 +
drivers/auxdisplay/Kconfig                    |   8 +
drivers/auxdisplay/Makefile                   |   1 +
drivers/auxdisplay/sensehat-display.c         | 188 ++++++++++++++++++
drivers/input/joystick/Kconfig                |  11 +
drivers/input/joystick/Makefile               |   1 +
drivers/input/joystick/sensehat-joystick.c    | 128 ++++++++++++
drivers/mfd/simple-mfd-i2c.c                  |   1 +
sensehat.dtbs                                 |  54 +++++
12 files changed, 532 insertions(+)
create mode 100644 Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml
create mode 100644 Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml
create mode 100644 Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
create mode 100644 drivers/auxdisplay/sensehat-display.c
create mode 100644 drivers/input/joystick/sensehat-joystick.c
create mode 100644 sensehat.dtbs
[PATCH v7 0/6] Raspberry Pi Sense HAT driver
Posted by Charles Mirabile 4 years, 3 months ago
This patch series adds a set of drivers for operating the Sense HAT
peripheral device. This board is an add on for the Raspberry Pi that is
designed to connect using the GPIO connector and communicates via I2C.

It features:
	- a joystick
	- an 8x8 RGB LED matrix display
	- a whole bunch of environmental sensors with their own drivers
	  (those are already in upstream Linux)

This is a refactor of the work of Serge Schneider, the author of a
version of this driver that is currently in the Raspberry Pi downstream
kernel. We modified his code to make it suitable for upstream Linux.

A couple of tests are available for the driver in the test folder in
this repo: https://github.com/underground-software/sensehat.git
	- sensehat_joystick_test logs the input events from the
	  joystick to the console
	- sensehat_display_test displays various solid colors on
	  the LED panel.
	- full_sensehat_test displays a single lit cell that can be
	  moved with the joystick. Pressing the joystick ends the
	  program.

For more information about the Sense HAT, visit:
https://www.raspberrypi.org/products/sense-hat/

Changes since v6:
	- we store the regmap for the sensehat inside the child structs
	  so that we don't need to look it up every time in the functions
	  that want to use it. Thanks to Nicolás Sáenz for the suggestion.
	- Changed userspace layout of the display driver to rgb565 triples
	  and removed the gamma table lookup and the associated ioctl. If
	  the user wants to recreate linear brightness scaling, they can
	  use a lookup table on their end. Doing this also removes a lot
	  of error checking and general code complexity, so I think removing
	  this feature is actually for the better.
	- Replaced if statement with call to `min_t` function in display
	  read and write functions.
	- Replaced the custom llseek implementation with a call to
	  `fixed_size_llseek`. Thanks to Miguel Ojeda for all of these
	  great suggestions.
	- Fixed issues with the yaml device tree bindings we missed last
	  time due to not having yamllint installed. Thanks for Rob Herring
	  (well his bot on his behalf :^)) for this suggestion.

Co-developed-by: Daniel Bauman <dbauman@redhat.com>
Signed-off-by: Daniel Bauman <dbauman@redhat.com>
Co-developed-by: Mwesigwa Guma <mguma@redhat.com>
Signed-off-by: Mwesigwa Guma <mguma@redhat.com>
Co-developed-by: Joel Savitz <jsavitz@redhat.com>
Signed-off-by: Joel Savitz <jsavitz@redhat.com>
Signed-off-by: Charles Mirabile <cmirabil@redhat.com>

Charles Mirabile (6):
  drivers/mfd: sensehat: Add Raspberry Pi Sense HAT to simple_mfd_i2c
  drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick
    driver
  drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver
  dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema
  MAINTAINERS: Add sensehat driver authors to MAINTAINERS
  DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4

 .../raspberrypi,sensehat-display.yaml         |  27 +++
 .../input/raspberrypi,sensehat-joystick.yaml  |  33 +++
 .../bindings/mfd/raspberrypi,sensehat.yaml    |  69 +++++++
 MAINTAINERS                                   |  11 +
 drivers/auxdisplay/Kconfig                    |   8 +
 drivers/auxdisplay/Makefile                   |   1 +
 drivers/auxdisplay/sensehat-display.c         | 188 ++++++++++++++++++
 drivers/input/joystick/Kconfig                |  11 +
 drivers/input/joystick/Makefile               |   1 +
 drivers/input/joystick/sensehat-joystick.c    | 128 ++++++++++++
 drivers/mfd/simple-mfd-i2c.c                  |   1 +
 sensehat.dtbs                                 |  54 +++++
 12 files changed, 532 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml
 create mode 100644 Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
 create mode 100644 drivers/auxdisplay/sensehat-display.c
 create mode 100644 drivers/input/joystick/sensehat-joystick.c
 create mode 100644 sensehat.dtbs

-- 
2.31.1

Re: [PATCH v7 0/6] Raspberry Pi Sense HAT driver
Posted by Miguel Ojeda 4 years, 3 months ago
On Thu, Mar 3, 2022 at 6:58 PM Charles Mirabile <cmirabil@redhat.com> wrote:
>
>         - Changed userspace layout of the display driver to rgb565 triples
>           and removed the gamma table lookup and the associated ioctl. If
>           the user wants to recreate linear brightness scaling, they can
>           use a lookup table on their end. Doing this also removes a lot
>           of error checking and general code complexity, so I think removing
>           this feature is actually for the better.

Sounds better indeed! If I understood correctly how it worked in the
previous round, it should also allow to use the hardware to a fuller
extent.

>         - Replaced if statement with call to `min_t` function in display
>           read and write functions.
>         - Replaced the custom llseek implementation with a call to
>           `fixed_size_llseek`. Thanks to Miguel Ojeda for all of these
>           great suggestions.

You're very welcome!

Cheers,
Miguel