power: supply: axp20x_ac_power: fix platform_get_irq.cocci warning

[PATCH] power: supply: axp20x_ac_power: fix platform_get_irq.cocci warning

Posted by Yihao Han 4 years, 3 months ago

Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/power/supply/axp20x_ac_power.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/power/supply/axp20x_ac_power.c b/drivers/power/supply/axp20x_ac_power.c
index ac360016b08a..57e50208d537 100644
--- a/drivers/power/supply/axp20x_ac_power.c
+++ b/drivers/power/supply/axp20x_ac_power.c
@@ -377,11 +377,9 @@ static int axp20x_ac_power_probe(struct platform_device *pdev)
 	/* Request irqs after registering, as irqs may trigger immediately */
 	for (i = 0; i < axp_data->num_irq_names; i++) {
 		irq = platform_get_irq_byname(pdev, axp_data->irq_names[i]);
-		if (irq < 0) {
-			dev_err(&pdev->dev, "No IRQ for %s: %d\n",
-				axp_data->irq_names[i], irq);
+		if (irq < 0)
 			return irq;
-		}
+
 		power->irqs[i] = regmap_irq_get_virq(axp20x->regmap_irqc, irq);
 		ret = devm_request_any_context_irq(&pdev->dev, power->irqs[i],
 						   axp20x_ac_power_irq, 0,
-- 
2.17.1

Re: [PATCH] power: supply: axp20x_ac_power: fix platform_get_irq.cocci warning

Posted by Sebastian Reichel 4 years, 3 months ago

Hi,

On Thu, Mar 03, 2022 at 04:27:19AM -0800, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
> 
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> 
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/axp20x_ac_power.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/power/supply/axp20x_ac_power.c b/drivers/power/supply/axp20x_ac_power.c
> index ac360016b08a..57e50208d537 100644
> --- a/drivers/power/supply/axp20x_ac_power.c
> +++ b/drivers/power/supply/axp20x_ac_power.c
> @@ -377,11 +377,9 @@ static int axp20x_ac_power_probe(struct platform_device *pdev)
>  	/* Request irqs after registering, as irqs may trigger immediately */
>  	for (i = 0; i < axp_data->num_irq_names; i++) {
>  		irq = platform_get_irq_byname(pdev, axp_data->irq_names[i]);
> -		if (irq < 0) {
> -			dev_err(&pdev->dev, "No IRQ for %s: %d\n",
> -				axp_data->irq_names[i], irq);
> +		if (irq < 0)
>  			return irq;
> -		}
> +
>  		power->irqs[i] = regmap_irq_get_virq(axp20x->regmap_irqc, irq);
>  		ret = devm_request_any_context_irq(&pdev->dev, power->irqs[i],
>  						   axp20x_ac_power_irq, 0,
> -- 
> 2.17.1
>