[PATCH 00/16] staging: r8188eu: convert functions to return bool

Vihas Makwana posted 16 patches 4 years, 3 months ago
drivers/staging/r8188eu/core/rtw_ieee80211.c    | 4 ++--
drivers/staging/r8188eu/core/rtw_mlme.c         | 2 +-
drivers/staging/r8188eu/core/rtw_pwrctrl.c      | 2 +-
drivers/staging/r8188eu/core/rtw_recv.c         | 7 +++----
drivers/staging/r8188eu/core/rtw_wlan_util.c    | 8 ++++----
drivers/staging/r8188eu/hal/rtl8188eu_xmit.c    | 2 +-
drivers/staging/r8188eu/include/ieee80211.h     | 4 ++--
drivers/staging/r8188eu/include/rtl8188e_xmit.h | 2 +-
drivers/staging/r8188eu/include/rtw_mlme.h      | 2 +-
drivers/staging/r8188eu/include/rtw_mlme_ext.h  | 6 +++---
drivers/staging/r8188eu/include/wifi.h          | 4 ++--
drivers/staging/r8188eu/include/xmit_osdep.h    | 2 +-
drivers/staging/r8188eu/os_dep/xmit_linux.c     | 2 +-
13 files changed, 23 insertions(+), 24 deletions(-)
[PATCH 00/16] staging: r8188eu: convert functions to return bool
Posted by Vihas Makwana 4 years, 3 months ago
There are many functions which return true/false but are marked as int, 
uint, s32 etc. Mark them as bool.

Vihas Makwana (16):
  staging: r8188eu: mark rtw_is_cckrates_included as bool
  staging: r8188eu: mark rtw_is_cckratesonly_included as bool
  staging: r8188eu: mark rtw_is_desired_network as bool
  staging: r8188eu: mark PS_RDY_CHECK as bool
  staging: r8188eu: mark check_indicate_seq as bool
  staging: r8188eu: mark enqueue_reorder_recvframe as bool
  staging: r8188eu: mark recv_indicatepkts_in_order as bool
  staging: r8188eu: mark cckrates_included as bool
  staging: r8188eu: mark cckratesonly_included as bool
  staging: r8188eu: mark is_basicrate as bool
  staging: r8188eu: mark is_ap_in_tkip as bool
  staging: r8188eu: mark rtl8188eu_xmitframe_complete as bool
  staging: r8188eu: mark check_fwstate as bool
  staging: r8188eu: mark IS_MCAST as bool
  staging: r8188eu: mark IsFrameTypeCtrl as bool
  staging: r8188eu: mark rtw_endofpktfile as bool

 drivers/staging/r8188eu/core/rtw_ieee80211.c    | 4 ++--
 drivers/staging/r8188eu/core/rtw_mlme.c         | 2 +-
 drivers/staging/r8188eu/core/rtw_pwrctrl.c      | 2 +-
 drivers/staging/r8188eu/core/rtw_recv.c         | 7 +++----
 drivers/staging/r8188eu/core/rtw_wlan_util.c    | 8 ++++----
 drivers/staging/r8188eu/hal/rtl8188eu_xmit.c    | 2 +-
 drivers/staging/r8188eu/include/ieee80211.h     | 4 ++--
 drivers/staging/r8188eu/include/rtl8188e_xmit.h | 2 +-
 drivers/staging/r8188eu/include/rtw_mlme.h      | 2 +-
 drivers/staging/r8188eu/include/rtw_mlme_ext.h  | 6 +++---
 drivers/staging/r8188eu/include/wifi.h          | 4 ++--
 drivers/staging/r8188eu/include/xmit_osdep.h    | 2 +-
 drivers/staging/r8188eu/os_dep/xmit_linux.c     | 2 +-
 13 files changed, 23 insertions(+), 24 deletions(-)

-- 
2.30.2
Re: [PATCH 00/16] staging: r8188eu: convert functions to return bool
Posted by Dan Carpenter 4 years, 3 months ago
On Thu, Mar 03, 2022 at 02:17:21AM +0530, Vihas Makwana wrote:
> There are many functions which return true/false but are marked as int, 
> uint, s32 etc. Mark them as bool.
> 
> Vihas Makwana (16):
>   staging: r8188eu: mark rtw_is_cckrates_included as bool
>   staging: r8188eu: mark rtw_is_cckratesonly_included as bool
>   staging: r8188eu: mark rtw_is_desired_network as bool
>   staging: r8188eu: mark PS_RDY_CHECK as bool
>   staging: r8188eu: mark check_indicate_seq as bool
>   staging: r8188eu: mark enqueue_reorder_recvframe as bool
>   staging: r8188eu: mark recv_indicatepkts_in_order as bool
>   staging: r8188eu: mark cckrates_included as bool
>   staging: r8188eu: mark cckratesonly_included as bool
>   staging: r8188eu: mark is_basicrate as bool
>   staging: r8188eu: mark is_ap_in_tkip as bool
>   staging: r8188eu: mark rtl8188eu_xmitframe_complete as bool
>   staging: r8188eu: mark check_fwstate as bool
>   staging: r8188eu: mark IS_MCAST as bool
>   staging: r8188eu: mark IsFrameTypeCtrl as bool
>   staging: r8188eu: mark rtw_endofpktfile as bool
> 

Looks good.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter