sched/deadline, (rt): Sched class cleanups

[PATCH 0/6] sched/deadline, (rt): Sched class cleanups

Posted by Dietmar Eggemann 4 years, 3 months ago

While trying to improve the Deadline sched class behaviour for
asymmetric CPU capacity systems I came across some possible
cleanups for DL (and RT).

Overview:

[PATCH 1/6] - Remove `struct dl_bandwidth def_dl_bandwidth`.

[PATCH 2/6] - Move functions into DL sched class which don't have to
              be exported.

[PATCH 3/6] - Merge two DL admission control functions which provide
              very similar functionality.

[PATCH 4/6] - Use DL rb_entry() macros and cached rbtree wrapper
              `rb_first_cached()` consistently.

[PATCH 5/6] - Remove unused !CONFIG_SMP function definitions in DL/RT.

[PATCH 6/6] - Remove redundant function parameter in DL/RT.

Dietmar Eggemann (6):
  sched/deadline: Remove unused def_dl_bandwidth
  sched/deadline: Move bandwidth mgmt and reclaim functions into sched
    class source file
  sched/deadline: Merge dl_task_can_attach() and dl_cpu_busy()
  sched/deadline: Use __node_2_[pdl|dle]() and rb_first_cached()
    consistently
  sched/deadline,rt: Remove unused functions for !CONFIG_SMP
  sched/deadline,rt: Remove unused parameter from
    pick_next_[rt|dl]_entity()

 kernel/sched/core.c     |  14 ++--
 kernel/sched/deadline.c | 141 ++++++++++++++++++++--------------------
 kernel/sched/rt.c       |  16 +----
 kernel/sched/sched.h    |  53 +--------------
 4 files changed, 84 insertions(+), 140 deletions(-)

-- 
2.25.1

Re: [PATCH 0/6] sched/deadline, (rt): Sched class cleanups

Posted by Juri Lelli 4 years, 3 months ago

Hi,

On 02/03/22 19:34, Dietmar Eggemann wrote:
> While trying to improve the Deadline sched class behaviour for
> asymmetric CPU capacity systems I came across some possible
> cleanups for DL (and RT).
> 
> Overview:
> 
> [PATCH 1/6] - Remove `struct dl_bandwidth def_dl_bandwidth`.
> 
> [PATCH 2/6] - Move functions into DL sched class which don't have to
>               be exported.
> 
> [PATCH 3/6] - Merge two DL admission control functions which provide
>               very similar functionality.
> 
> [PATCH 4/6] - Use DL rb_entry() macros and cached rbtree wrapper
>               `rb_first_cached()` consistently.
> 
> [PATCH 5/6] - Remove unused !CONFIG_SMP function definitions in DL/RT.
> 
> [PATCH 6/6] - Remove redundant function parameter in DL/RT.
> 
> Dietmar Eggemann (6):
>   sched/deadline: Remove unused def_dl_bandwidth
>   sched/deadline: Move bandwidth mgmt and reclaim functions into sched
>     class source file
>   sched/deadline: Merge dl_task_can_attach() and dl_cpu_busy()
>   sched/deadline: Use __node_2_[pdl|dle]() and rb_first_cached()
>     consistently
>   sched/deadline,rt: Remove unused functions for !CONFIG_SMP
>   sched/deadline,rt: Remove unused parameter from
>     pick_next_[rt|dl]_entity()
> 
>  kernel/sched/core.c     |  14 ++--
>  kernel/sched/deadline.c | 141 ++++++++++++++++++++--------------------
>  kernel/sched/rt.c       |  16 +----
>  kernel/sched/sched.h    |  53 +--------------
>  4 files changed, 84 insertions(+), 140 deletions(-)

These look ok to me. Thanks for the cleanups!

Acked-by: Juri Lelli <juri.lelli@redhat.com>

Best,
Juri

Re: [PATCH 0/6] sched/deadline, (rt): Sched class cleanups

Posted by Peter Zijlstra 4 years, 3 months ago

On Fri, Mar 04, 2022 at 10:21:49AM +0100, Juri Lelli wrote:
> Hi,
> 
> On 02/03/22 19:34, Dietmar Eggemann wrote:
> > While trying to improve the Deadline sched class behaviour for
> > asymmetric CPU capacity systems I came across some possible
> > cleanups for DL (and RT).
> > 
> > Overview:
> > 
> > [PATCH 1/6] - Remove `struct dl_bandwidth def_dl_bandwidth`.
> > 
> > [PATCH 2/6] - Move functions into DL sched class which don't have to
> >               be exported.
> > 
> > [PATCH 3/6] - Merge two DL admission control functions which provide
> >               very similar functionality.
> > 
> > [PATCH 4/6] - Use DL rb_entry() macros and cached rbtree wrapper
> >               `rb_first_cached()` consistently.
> > 
> > [PATCH 5/6] - Remove unused !CONFIG_SMP function definitions in DL/RT.
> > 
> > [PATCH 6/6] - Remove redundant function parameter in DL/RT.
> > 
> > Dietmar Eggemann (6):
> >   sched/deadline: Remove unused def_dl_bandwidth
> >   sched/deadline: Move bandwidth mgmt and reclaim functions into sched
> >     class source file
> >   sched/deadline: Merge dl_task_can_attach() and dl_cpu_busy()
> >   sched/deadline: Use __node_2_[pdl|dle]() and rb_first_cached()
> >     consistently
> >   sched/deadline,rt: Remove unused functions for !CONFIG_SMP
> >   sched/deadline,rt: Remove unused parameter from
> >     pick_next_[rt|dl]_entity()
> > 
> >  kernel/sched/core.c     |  14 ++--
> >  kernel/sched/deadline.c | 141 ++++++++++++++++++++--------------------
> >  kernel/sched/rt.c       |  16 +----
> >  kernel/sched/sched.h    |  53 +--------------
> >  4 files changed, 84 insertions(+), 140 deletions(-)
> 
> These look ok to me. Thanks for the cleanups!
> 
> Acked-by: Juri Lelli <juri.lelli@redhat.com>

Thanks!