[PATCH] drm: Fix no previous prototype error in drm_nomodeset.c

Aashish Sharma posted 1 patch 4 years, 3 months ago
drivers/gpu/drm/drm_nomodeset.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] drm: Fix no previous prototype error in drm_nomodeset.c
Posted by Aashish Sharma 4 years, 3 months ago
Fix this kernel test robot error:

drivers/gpu/drm/drm_nomodeset.c:8:6: error:
no previous prototype for 'drm_firmware_drivers_only'

Including drm_drv.h in drm_nomodeset.c which contains
drm_firmware_drivers_only's declaration.

Signed-off-by: Aashish Sharma <shraash@google.com>
---
 drivers/gpu/drm/drm_nomodeset.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/drm_nomodeset.c b/drivers/gpu/drm/drm_nomodeset.c
index f3978d5bd3a1..9402deb4985f 100644
--- a/drivers/gpu/drm/drm_nomodeset.c
+++ b/drivers/gpu/drm/drm_nomodeset.c
@@ -2,6 +2,7 @@
 
 #include <linux/module.h>
 #include <linux/types.h>
+#include <drm/drm_drv.h>
 
 static bool drm_nomodeset;
 
-- 
2.35.1.574.g5d30c73bfb-goog
Re: [PATCH] drm: Fix no previous prototype error in drm_nomodeset.c
Posted by Guenter Roeck 4 years, 3 months ago
On Wed, Mar 02, 2022 at 10:39:02PM +0530, Aashish Sharma wrote:
> Fix this kernel test robot error:
> 
> drivers/gpu/drm/drm_nomodeset.c:8:6: error:
> no previous prototype for 'drm_firmware_drivers_only'
> 
> Including drm_drv.h in drm_nomodeset.c which contains
> drm_firmware_drivers_only's declaration.
> 
> Signed-off-by: Aashish Sharma <shraash@google.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/gpu/drm/drm_nomodeset.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_nomodeset.c b/drivers/gpu/drm/drm_nomodeset.c
> index f3978d5bd3a1..9402deb4985f 100644
> --- a/drivers/gpu/drm/drm_nomodeset.c
> +++ b/drivers/gpu/drm/drm_nomodeset.c
> @@ -2,6 +2,7 @@
>  
>  #include <linux/module.h>
>  #include <linux/types.h>
> +#include <drm/drm_drv.h>
>  
>  static bool drm_nomodeset;
>  
> -- 
> 2.35.1.574.g5d30c73bfb-goog
>