[PATCH] video: fbdev: s3c-fb: fix platform_get_irq.cocci warning

Yihao Han posted 1 patch 4 years, 3 months ago
drivers/video/fbdev/s3c-fb.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] video: fbdev: s3c-fb: fix platform_get_irq.cocci warning
Posted by Yihao Han 4 years, 3 months ago
Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/video/fbdev/s3c-fb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index 208514054c23..3abbc5737c3b 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -1418,7 +1418,6 @@ static int s3c_fb_probe(struct platform_device *pdev)
 
 	sfb->irq_no = platform_get_irq(pdev, 0);
 	if (sfb->irq_no < 0) {
-		dev_err(dev, "failed to acquire irq resource\n");
 		ret = -ENOENT;
 		goto err_lcd_clk;
 	}
-- 
2.17.1
Re: [PATCH] video: fbdev: s3c-fb: fix platform_get_irq.cocci warning
Posted by Helge Deller 4 years, 3 months ago
On 3/2/22 04:44, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>

applied to the fbdev for-next git tree.

Thanks!
Helge

> ---
>  drivers/video/fbdev/s3c-fb.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index 208514054c23..3abbc5737c3b 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1418,7 +1418,6 @@ static int s3c_fb_probe(struct platform_device *pdev)
>
>  	sfb->irq_no = platform_get_irq(pdev, 0);
>  	if (sfb->irq_no < 0) {
> -		dev_err(dev, "failed to acquire irq resource\n");
>  		ret = -ENOENT;
>  		goto err_lcd_clk;
>  	}