[PATCH] power: supply: axp20x_usb_power: fix platform_get_irq.cocci warnings

Yihao Han posted 1 patch 4 years, 3 months ago
drivers/power/supply/axp20x_usb_power.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] power: supply: axp20x_usb_power: fix platform_get_irq.cocci warnings
Posted by Yihao Han 4 years, 3 months ago
Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/power/supply/axp20x_usb_power.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c
index a1d110f7ddce..75170fe79cbf 100644
--- a/drivers/power/supply/axp20x_usb_power.c
+++ b/drivers/power/supply/axp20x_usb_power.c
@@ -638,8 +638,6 @@ static int axp20x_usb_power_probe(struct platform_device *pdev)
 	for (i = 0; i < axp_data->num_irq_names; i++) {
 		irq = platform_get_irq_byname(pdev, axp_data->irq_names[i]);
 		if (irq < 0) {
-			dev_err(&pdev->dev, "No IRQ for %s: %d\n",
-				axp_data->irq_names[i], irq);
 			return irq;
 		}
 		power->irqs[i] = regmap_irq_get_virq(axp20x->regmap_irqc, irq);
-- 
2.17.1
Re: [PATCH] power: supply: axp20x_usb_power: fix platform_get_irq.cocci warnings
Posted by Sebastian Reichel 4 years, 3 months ago
Hi,

On Tue, Mar 01, 2022 at 06:34:51PM -0800, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
> 
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> 
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---

Thanks, queued (slightly modified to remove the now useless {}).

-- Sebastian

>  drivers/power/supply/axp20x_usb_power.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c
> index a1d110f7ddce..75170fe79cbf 100644
> --- a/drivers/power/supply/axp20x_usb_power.c
> +++ b/drivers/power/supply/axp20x_usb_power.c
> @@ -638,8 +638,6 @@ static int axp20x_usb_power_probe(struct platform_device *pdev)
>  	for (i = 0; i < axp_data->num_irq_names; i++) {
>  		irq = platform_get_irq_byname(pdev, axp_data->irq_names[i]);
>  		if (irq < 0) {
> -			dev_err(&pdev->dev, "No IRQ for %s: %d\n",
> -				axp_data->irq_names[i], irq);
>  			return irq;
>  		}
>  		power->irqs[i] = regmap_irq_get_virq(axp20x->regmap_irqc, irq);
> -- 
> 2.17.1
>