ext4: remove redundant assignment to variable split_flag1

[PATCH] ext4: remove redundant assignment to variable split_flag1

Posted by Colin Ian King 4 years, 3 months ago

Variable split_flag1 is being assigned a value that is never read,
it is being re-assigned a new value in the following code block.
The assignment is redundant and can be removed.

Cleans up clang scan build warning:
fs/ext4/extents.c:3371:2: warning: Value stored to 'split_flag1' is
never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 fs/ext4/extents.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index c0f3f83e0c1b..0d98cf402282 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3368,7 +3368,6 @@ static int ext4_split_extent(handle_t *handle,
 		return -EFSCORRUPTED;
 	}
 	unwritten = ext4_ext_is_unwritten(ex);
-	split_flag1 = 0;
 
 	if (map->m_lblk >= ee_block) {
 		split_flag1 = split_flag & EXT4_EXT_DATA_VALID2;
-- 
2.34.1

Re: [PATCH] ext4: remove redundant assignment to variable split_flag1

Posted by Theodore Ts'o 4 years, 3 months ago

On Tue, 1 Mar 2022 12:16:44 +0000, Colin Ian King wrote:
> Variable split_flag1 is being assigned a value that is never read,
> it is being re-assigned a new value in the following code block.
> The assignment is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> fs/ext4/extents.c:3371:2: warning: Value stored to 'split_flag1' is
> never read [deadcode.DeadStores]
> 
> [...]

Applied, thanks!

[1/1] ext4: remove redundant assignment to variable split_flag1
      commit: 6b71b69dd98b197deea0806417e88308e0876a10

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>