[PATCH] nfp: avoid newline at end of message in NL_SET_ERR_MSG_MOD

Wan Jiabing posted 1 patch 4 years, 3 months ago
drivers/net/ethernet/netronome/nfp/flower/qos_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] nfp: avoid newline at end of message in NL_SET_ERR_MSG_MOD
Posted by Wan Jiabing 4 years, 3 months ago
Fix the following coccicheck warning:
./drivers/net/ethernet/netronome/nfp/flower/qos_conf.c:750:7-55: WARNING
avoid newline at end of message in NL_SET_ERR_MSG_MOD

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/net/ethernet/netronome/nfp/flower/qos_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/netronome/nfp/flower/qos_conf.c b/drivers/net/ethernet/netronome/nfp/flower/qos_conf.c
index cd3fdb9f953b..3206ba83b1aa 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/qos_conf.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/qos_conf.c
@@ -747,7 +747,7 @@ nfp_act_remove_actions(struct nfp_app *app, struct flow_offload_action *fl_act,
 	meter_entry = nfp_flower_search_meter_entry(app, meter_id);
 	if (!meter_entry) {
 		NL_SET_ERR_MSG_MOD(extack,
-				   "no meter entry when delete the action index.\n");
+				   "no meter entry when delete the action index.");
 		return -ENOENT;
 	}
 	pps = !meter_entry->bps;
-- 
2.35.1
Re: [PATCH] nfp: avoid newline at end of message in NL_SET_ERR_MSG_MOD
Posted by patchwork-bot+netdevbpf@kernel.org 4 years, 3 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  1 Mar 2022 19:23:54 +0800 you wrote:
> Fix the following coccicheck warning:
> ./drivers/net/ethernet/netronome/nfp/flower/qos_conf.c:750:7-55: WARNING
> avoid newline at end of message in NL_SET_ERR_MSG_MOD
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  drivers/net/ethernet/netronome/nfp/flower/qos_conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - nfp: avoid newline at end of message in NL_SET_ERR_MSG_MOD
    https://git.kernel.org/netdev/net-next/c/323d51cac6a1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] nfp: avoid newline at end of message in NL_SET_ERR_MSG_MOD
Posted by Simon Horman 4 years, 3 months ago
On Tue, Mar 01, 2022 at 07:23:54PM +0800, Wan Jiabing wrote:
> Fix the following coccicheck warning:
> ./drivers/net/ethernet/netronome/nfp/flower/qos_conf.c:750:7-55: WARNING
> avoid newline at end of message in NL_SET_ERR_MSG_MOD
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Thanks Wan Jiabing,

much appreciated.

Reviewed-by: Simon Horman <simon.horman@corigine.com>