drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Fix following coccicheck warning:
drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c:316:11-12:
WARNING this kind of initialization is deprecated.
`void *map = map` has the same form of
uninitialized_var() macro. I remove the redundant assignement. It has
been tested with gcc (Debian 8.3.0-6) 8.3.0.
The patch which removed uninitialized_var() is:
https://lore.kernel.org/all/20121028102007.GA7547@gmail.com/
And there is very few "/* GCC */" comments in the Linux kernel code now.
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c b/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c
index 96aca0edfa3c..c51bac76174c 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c
@@ -313,7 +313,7 @@ nv50_instobj_dtor(struct nvkm_memory *memory)
struct nv50_instobj *iobj = nv50_instobj(memory);
struct nvkm_instmem *imem = &iobj->imem->base;
struct nvkm_vma *bar;
- void *map = map;
+ void *map;
mutex_lock(&imem->mutex);
if (likely(iobj->lru.next))
--
2.20.1
Reviewed-by: Lyude Paul <lyude@redhat.com> Will push this to the appropriate drm-misc repository in just a little bit On Mon, 2022-02-28 at 22:23 +0800, Guo Zhengkui wrote: > Fix following coccicheck warning: > drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c:316:11-12: > WARNING this kind of initialization is deprecated. > > `void *map = map` has the same form of > uninitialized_var() macro. I remove the redundant assignement. It has > been tested with gcc (Debian 8.3.0-6) 8.3.0. > > The patch which removed uninitialized_var() is: > https://lore.kernel.org/all/20121028102007.GA7547@gmail.com/ > And there is very few "/* GCC */" comments in the Linux kernel code now. > > Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com> > --- > drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c > index 96aca0edfa3c..c51bac76174c 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c > @@ -313,7 +313,7 @@ nv50_instobj_dtor(struct nvkm_memory *memory) > struct nv50_instobj *iobj = nv50_instobj(memory); > struct nvkm_instmem *imem = &iobj->imem->base; > struct nvkm_vma *bar; > - void *map = map; > + void *map; > > mutex_lock(&imem->mutex); > if (likely(iobj->lru.next)) -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat
© 2016 - 2026 Red Hat, Inc.